Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2083)

Unified Diff: pkg/docgen/lib/src/models/class.dart

Issue 730163002: Fix leftover checks for dart- names in docgen (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/docgen/lib/src/models/doc_gen_type.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/docgen/lib/src/models/class.dart
diff --git a/pkg/docgen/lib/src/models/class.dart b/pkg/docgen/lib/src/models/class.dart
index 07cfb81ed62876855796a94a5c77233c9f576476..f323eb57a34baad9e9b07e5a429b90e5a3f95a76 100644
--- a/pkg/docgen/lib/src/models/class.dart
+++ b/pkg/docgen/lib/src/models/class.dart
@@ -168,7 +168,7 @@ class Class extends OwnedIndexable<dart2js_mirrors.Dart2JsInterfaceTypeMirror>
/// If [this] is private (or an intermediary mixin class), it will add the
/// subclass to the list of subclasses in the superclasses.
void addSubclass(Class subclass) {
- if (docName == 'dart-core.Object') return;
+ if (docName == 'dart:core.Object') return;
if (!includePrivateMembers && isPrivate || mirror.isNameSynthetic) {
if (_superclass != null) _superclass.addSubclass(subclass);
@@ -182,8 +182,8 @@ class Class extends OwnedIndexable<dart2js_mirrors.Dart2JsInterfaceTypeMirror>
/// Check if this [Class] is an error or exception.
bool isError() {
- if (qualifiedName == 'dart-core.Error' ||
- qualifiedName == 'dart-core.Exception')
+ if (qualifiedName == 'dart:core.Error' ||
+ qualifiedName == 'dart:core.Exception')
return true;
for (var interface in interfaces) {
if (interface.isError()) return true;
@@ -215,7 +215,7 @@ class Class extends OwnedIndexable<dart2js_mirrors.Dart2JsInterfaceTypeMirror>
/// If a class extends a private superclass, find the closest public
/// superclass of the private superclass.
String validSuperclass() {
- if (_superclass == null) return 'dart-core.Object';
+ if (_superclass == null) return 'dart:core.Object';
if (_superclass.isVisible) return _superclass.qualifiedName;
return _superclass.validSuperclass();
}
« no previous file with comments | « no previous file | pkg/docgen/lib/src/models/doc_gen_type.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698