Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 730133003: Android: use demuxer configs for video output size. (Closed)

Created:
6 years, 1 month ago by gunsch
Modified:
6 years, 1 month ago
Reviewers:
qinmin
CC:
chromium-reviews, posciak+watch_chromium.org, wjia+watch_chromium.org, avayvod+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Android: use demuxer configs for video output size. The values reported from MediaCodec.GetOutputFormat (once the crop rectangle is accounted for) correspond to the actual video size, but not necessarily the size that should be outputted. Some videos appear to report a different aspect ratio in their config than the actual video data, but the reported aspect ratio is what it should be displayed at. R=qinmin@chromium.org BUG=internal b/18224769 Committed: https://crrev.com/53a8876984c7593bab28a31e19ccdc904638c19e Cr-Commit-Position: refs/heads/master@{#304477}

Patch Set 1 #

Total comments: 2

Patch Set 2 : documents UpdateOutputFormat reasoning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M media/base/android/video_decoder_job.cc View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
gunsch
6 years, 1 month ago (2014-11-17 19:13:39 UTC) #1
qinmin
https://codereview.chromium.org/730133003/diff/1/media/base/android/video_decoder_job.cc File media/base/android/video_decoder_job.cc (right): https://codereview.chromium.org/730133003/diff/1/media/base/android/video_decoder_job.cc#newcode161 media/base/android/video_decoder_job.cc:161: output_width_ = config_width_; please add a link to the ...
6 years, 1 month ago (2014-11-17 19:55:48 UTC) #2
gunsch
https://codereview.chromium.org/730133003/diff/1/media/base/android/video_decoder_job.cc File media/base/android/video_decoder_job.cc (right): https://codereview.chromium.org/730133003/diff/1/media/base/android/video_decoder_job.cc#newcode161 media/base/android/video_decoder_job.cc:161: output_width_ = config_width_; On 2014/11/17 19:55:48, qinmin wrote: > ...
6 years, 1 month ago (2014-11-17 20:04:45 UTC) #3
qinmin
lgtm
6 years, 1 month ago (2014-11-17 20:09:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/730133003/20001
6 years, 1 month ago (2014-11-17 20:15:57 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-17 21:09:05 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-17 21:09:42 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/53a8876984c7593bab28a31e19ccdc904638c19e
Cr-Commit-Position: refs/heads/master@{#304477}

Powered by Google App Engine
This is Rietveld 408576698