Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 73013003: Update the python auto-install on Windows to 2.7.6. (Closed)

Created:
7 years, 1 month ago by M-A Ruel
Modified:
7 years, 1 month ago
Reviewers:
iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Update the python auto-install on Windows to 2.7.6. 2.7.5 has bug http://bugs.python.org/issue17998 in re package that is affecting the chromium team so it can't be used. The bug is fixed in 2.7.6. This update still respects DEPOT_TOOLS_PYTHON_275=0. Since the name doesn't represent what is being installed, it also respects DEPOT_TOOLS_PYTHON_27=0. R=iannucci@chromium.org BUG=241769 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235384

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -24 lines) Patch
D bootstrap/win/python275.new.bat View 1 chunk +0 lines, -8 lines 0 comments Download
A + bootstrap/win/python276.new.bat View 1 chunk +2 lines, -2 lines 0 comments Download
M bootstrap/win/win_tools.bat View 2 chunks +17 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
7 years, 1 month ago (2013-11-15 16:20:24 UTC) #1
M-A Ruel
The zip was added earlier today in r235340. As a reference, here's the content of ...
7 years, 1 month ago (2013-11-15 16:25:17 UTC) #2
iannucci
lgtm. Pretty unbelievable that 1) This bug exists, 2) We actually hit it.
7 years, 1 month ago (2013-11-15 18:37:32 UTC) #3
M-A Ruel
7 years, 1 month ago (2013-11-15 18:39:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r235384.

Powered by Google App Engine
This is Rietveld 408576698