Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 73013002: [Clean up] Replace SearchTabHelper NAV_ENTRY_COMMITTED notification observer with WebContentsObserve (Closed)

Created:
7 years, 1 month ago by kmadhusu
Modified:
7 years, 1 month ago
Reviewers:
samarth
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Visibility:
Public.

Description

[Clean up] Replace SearchTabHelper NAV_ENTRY_COMMITTED notification observer with WebContentsObserver::NavigationEntryCommitted(). BUG=272583, 268984 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235706

Patch Set 1 : '' #

Patch Set 2 : Rebase #

Patch Set 3 : Fix android compile error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -75 lines) Patch
M chrome/browser/ui/search/search_tab_helper.h View 1 2 5 chunks +4 lines, -11 lines 0 comments Download
M chrome/browser/ui/search/search_tab_helper.cc View 4 chunks +51 lines, -64 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
kmadhusu
7 years, 1 month ago (2013-11-14 21:22:05 UTC) #1
Avi (use Gerrit)
Sweet; thank you!
7 years, 1 month ago (2013-11-14 21:25:27 UTC) #2
samarth
LGTM thanks!
7 years, 1 month ago (2013-11-15 00:20:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/73013002/110001
7 years, 1 month ago (2013-11-15 02:38:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/73013002/110001
7 years, 1 month ago (2013-11-15 04:27:51 UTC) #5
commit-bot: I haz the power
Retried try job too often on android_clang_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_clang_dbg&number=93031
7 years, 1 month ago (2013-11-15 05:33:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/73013002/380001
7 years, 1 month ago (2013-11-15 18:09:10 UTC) #7
commit-bot: I haz the power
Retried try job too often on android_clang_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_clang_dbg&number=93188
7 years, 1 month ago (2013-11-15 19:11:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/73013002/550002
7 years, 1 month ago (2013-11-15 19:42:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/73013002/550002
7 years, 1 month ago (2013-11-15 22:29:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/73013002/550002
7 years, 1 month ago (2013-11-16 01:19:56 UTC) #11
commit-bot: I haz the power
7 years, 1 month ago (2013-11-18 11:37:00 UTC) #12
Message was sent while issue was closed. 
Change committed as 235706

Powered by Google App Engine
This is Rietveld 408576698