Introduce new API orientation() to expose aria-orientation correctly.

Source/modules/accessibility/AXRenderObject.cpp

 /*
 * Copyright (C) 2008 Apple Inc. All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions
 * are met:
 *
 * 1.  Redistributions of source code must retain the above copyright
 *     notice, this list of conditions and the following disclaimer.
 * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 830 matching lines @@
     if (!node)
         return nullAtom;
     if (!node->isElementNode())
         return nullAtom;
     return toElement(node)->getAttribute(accesskeyAttr);
 }
 
 AccessibilityOrientation AXRenderObject::orientation() const
 {
     const AtomicString& ariaOrientation = getAttribute(aria_orientationAttr);
+    AccessibilityOrientation axorientation = AccessibilityOrientationUndefined;
+
+    switch (roleValue()) {
+    case ComboBoxRole:
+    case ListBoxRole:
+    case MenuRole:
+    case ScrollBarRole:
+    case TreeRole:
+        axorientation = AccessibilityOrientationVertical;
+        break;
+    case MenuBarRole:
+    case SliderRole:
+    case SplitterRole:
+    case TabListRole:
+    case ToolbarRole:
+        axorientation = AccessibilityOrientationHorizontal;
+        break;
+    case RadioGroupRole:
+    case TreeGridRole:

[shreeramk, 2014/11/21 11:07:47]

Here, TreeGridRole case is not true.

Reason: roleValue() for role="treegrid" is coming TableRole(111).

My proposed Solution:
ariaRoleAttribute() for TreeGridRole can be checked in the ifs.

e.g
if (equalIgnoringCase(ariaOrientation, "horizontal") || ariaRoleAttribute() ==
TreeGridRole)

Whats your view on this?

[dmazzoni, 2014/11/24 17:36:59]

The logic sounds great.

To make the code more readable, I'd maybe put the TreeGridRole on its own line
with a comment.

if (equalIgnoringCase(ariaOrientation, "horizontal"))
    ...

// Comment explaining why this overrides...
if (ariaRoleAttribute() == TreeGridRole)
    axorientation = AccessibilityOrientationHorizontal;

[shreeramk, 2014/11/25 08:58:37]

Added code for TreeGridRole.

+        break;
+    default:
+        return AXObject::orientation();
+    }
+
     if (equalIgnoringCase(ariaOrientation, "horizontal"))
-        return AccessibilityOrientationHorizontal;
+        axorientation = AccessibilityOrientationHorizontal;
     if (equalIgnoringCase(ariaOrientation, "vertical"))
-        return AccessibilityOrientationVertical;
-
-    if (isScrollbar())
-        return AccessibilityOrientationVertical;
-
-    return AXObject::orientation();
+        axorientation = AccessibilityOrientationVertical;
+    return axorientation;
 }
 
 String AXRenderObject::text() const
 {
     if (isPasswordFieldAndShouldHideValue())
         return String();
 
     return AXNodeObject::text();
 }
 
@@ skipping 1583 matching lines @@
         if (label && label->renderer()) {
             LayoutRect labelRect = axObjectCache()->getOrCreate(label)->elementRect();
             result.unite(labelRect);
         }
     }
 
     return result;
 }
 
 } // namespace blink