Introduce new API orientation() to expose aria-orientation correctly.

Source/modules/accessibility/AXRenderObject.cpp

 /*
 * Copyright (C) 2008 Apple Inc. All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions
 * are met:
 *
 * 1.  Redistributions of source code must retain the above copyright
 *     notice, this list of conditions and the following disclaimer.
 * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 829 matching lines @@
     Node* node = m_renderer->node();
     if (!node)
         return nullAtom;
     if (!node->isElementNode())
         return nullAtom;
     return toElement(node)->getAttribute(accesskeyAttr);
 }
 
 AccessibilityOrientation AXRenderObject::orientation() const
 {
-    const AtomicString& ariaOrientation = getAttribute(aria_orientationAttr);
-    if (equalIgnoringCase(ariaOrientation, "horizontal"))
-        return AccessibilityOrientationHorizontal;
-    if (equalIgnoringCase(ariaOrientation, "vertical"))
-        return AccessibilityOrientationVertical;
+    if (ariaRoleAttribute() == ComboBoxRole

[dmazzoni, 2014/11/20 16:48:06]

You're only checking the aria role, but some of these have native controls that
should return an orientation. In particular:

splitter
slider
combobox
listbox
scrollbar

I know for sure that all of those roles can come from native HTML elements and
we should return an orientation from all of those. I think it'd make sense to
just check the role - not the aria role.

Use switch statements when there's more than 2 or 3 tests.

Instead of putting nearly the whole body of a function inside an "if" block,
reverse the order of the test - i.e. after the first switch, if the role is NOT
one that needs an orientation, return AXObject::orientation - then the rest of
the function doesn't need to be indented.

+        || ariaRoleAttribute() == ListBoxRole
+        || ariaRoleAttribute() == MenuRole
+        || ariaRoleAttribute() == MenuBarRole
+        || ariaRoleAttribute() == RadioGroupRole
+        || ariaRoleAttribute() == ScrollBarRole
+        || ariaRoleAttribute() == SliderRole
+        || ariaRoleAttribute() == SplitterRole
+        || ariaRoleAttribute() == TabListRole
+        || ariaRoleAttribute() == ToolbarRole
+        || ariaRoleAttribute() == TreeRole
+        || ariaRoleAttribute() == TreeGridRole) {
 
-    if (isScrollbar())
-        return AccessibilityOrientationVertical;
+        const AtomicString& ariaOrientation = getAttribute(aria_orientationAttr);
+
+        // Adding implicit horizontal orientation
+        if (equalIgnoringCase(ariaOrientation, "horizontal")
+            || ariaRoleAttribute() == MenuBarRole
+            || ariaRoleAttribute() == SplitterRole
+            || ariaRoleAttribute() == SliderRole
+            || ariaRoleAttribute() == TabListRole
+            || ariaRoleAttribute() == ToolbarRole)
+            return AccessibilityOrientationHorizontal;
+
+        // Adding implicit vertical orientation
+        if (equalIgnoringCase(ariaOrientation, "vertical")
+            || ariaRoleAttribute() == ComboBoxRole
+            || ariaRoleAttribute() == ListBoxRole
+            || ariaRoleAttribute() == MenuRole
+            || ariaRoleAttribute() == ScrollBarRole
+            || ariaRoleAttribute() == TreeRole)
+            return AccessibilityOrientationVertical;
+    }
 
     return AXObject::orientation();
 }
 
 String AXRenderObject::text() const
 {
     if (isPasswordFieldAndShouldHideValue())
         return String();
 
     return AXNodeObject::text();
@@ skipping 1576 matching lines @@
         if (label && label->renderer()) {
             LayoutRect labelRect = axObjectCache()->getOrCreate(label)->elementRect();
             result.unite(labelRect);
         }
     }
 
     return result;
 }
 
 } // namespace blink