Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 730053004: Add speech output rules for most of the remaining native views for ChromeVox Next. (Closed)

Created:
6 years, 1 month ago by David Tseng
Modified:
6 years, 1 month ago
Reviewers:
dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nkostylev+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@space_command
Project:
chromium
Visibility:
Public.

Description

Add speech output rules for most of the remaining native views for ChromeVox Next. Committed: https://crrev.com/94048e5fc9e0064116d9199aaf5db970f9d1c205 Cr-Commit-Position: refs/heads/master@{#304702}

Patch Set 1 #

Patch Set 2 : Hack for braille. #

Patch Set 3 : Rebase. #

Patch Set 4 : Set default value. #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -13 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 1 2 3 4 8 chunks +63 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
David Tseng
Most views are now covered with the noteable exception of tree views. That views as ...
6 years, 1 month ago (2014-11-17 21:58:01 UTC) #2
dmazzoni
lgtm
6 years, 1 month ago (2014-11-17 22:38:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/730053004/70001
6 years, 1 month ago (2014-11-18 22:35:44 UTC) #5
commit-bot: I haz the power
Committed patchset #5 (id:70001)
6 years, 1 month ago (2014-11-18 23:49:01 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-18 23:49:49 UTC) #7
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/94048e5fc9e0064116d9199aaf5db970f9d1c205
Cr-Commit-Position: refs/heads/master@{#304702}

Powered by Google App Engine
This is Rietveld 408576698