Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 730043002: [turbofan] Fix pushing of JSToBooleans into Phis. (Closed)

Created:
6 years, 1 month ago by Benedikt Meurer
Modified:
6 years, 1 month ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix pushing of JSToBooleans into Phis. Now we actually implement it the way it is meant to be, that is: JSToBoolean(Phi(x1,...,xn):primitive) => Phi(JSToBoolean(x1),...,JSToBoolean(xn)):boolean This also fixes the endless recursion within JSTypedLowering when the GraphReducer does all possible reductions instead of using the generic algorithm. R=dcarney@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/2eaca10e9bdc18cb1127db05613313109a374d0e

Patch Set 1 #

Patch Set 2 : Fixes #

Patch Set 3 : Fix invalid asserts. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -32 lines) Patch
M src/compiler/js-typed-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 2 3 chunks +45 lines, -32 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
6 years, 1 month ago (2014-11-17 11:49:40 UTC) #1
Benedikt Meurer
PTAL
6 years, 1 month ago (2014-11-17 11:54:23 UTC) #2
dcarney
lgtm
6 years, 1 month ago (2014-11-17 12:03:46 UTC) #3
Benedikt Meurer
6 years, 1 month ago (2014-11-17 12:11:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
2eaca10e9bdc18cb1127db05613313109a374d0e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698