tools/perf/benchmarks/skpicture_printer.py - Issue 730033005: telemetry: Add ct_run_benchmark to run benchmarks in CT's repository

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/skpicture_printer.py

Issue 730033005: telemetry: Add ct_run_benchmark to run benchmarks in CT's repository (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/benchmarks/skpicture_printer.py

diff --git a/tools/perf/benchmarks/skpicture_printer.py b/tools/perf/benchmarks/skpicture_printer.py

index 931e91730f6359f4c6f4b6721e33e64ff28c5955..3f29edcda04cb95197c322394cf51a182c10a9d4 100644

--- a/tools/perf/benchmarks/skpicture_printer.py

+++ b/tools/perf/benchmarks/skpicture_printer.py

@@ -8,7 +8,7 @@ from telemetry.core import discover

from telemetry.page import page_set

-def _MatchPageSetName(page_set_name, page_set_base_dir):

+def MatchPageSetName(page_set_name, page_set_base_dir):

ernstm 2014/11/24 20:15:38 Why does this need to become a public method of th

page_sets = []

page_sets += discover.DiscoverClasses(page_set_base_dir, page_set_base_dir,

page_set.PageSet,

@@ -40,6 +40,6 @@ class SkpicturePrinter(benchmark.Benchmark):

return skpicture_printer.SkpicturePrinter(options.skp_outdir)

def CreatePageSet(self, options):

- page_set_class = _MatchPageSetName(options.page_set_name,

- options.page_set_base_dir)

+ page_set_class = MatchPageSetName(options.page_set_name,

+ options.page_set_base_dir)

return page_set_class()

« no previous file with comments | « no previous file | tools/perf/ct_run_benchmark » ('j') | no next file with comments »