Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 730003003: Add a UseCounter for Text.wholeText (Closed)

Created:
6 years, 1 month ago by philipj_slow
Modified:
6 years, 1 month ago
Reviewers:
pdr.
CC:
arv+blink, blink-reviews, blink-reviews-dom_chromium.org, Inactive, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Project:
blink
Visibility:
Public.

Description

Add a UseCounter for Text.wholeText Text.replaceWholeText() was removed from DOM and has very low usage: https://www.chromestatus.com/metrics/feature/timeline/popularity/100 Measure Text.wholeText also to see if it is similarly unused. Discussed briefly with Anne van Kesteren on IRC: http://krijnhoetmer.nl/irc-logs/whatwg/20141117#l-248 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185453

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/core/dom/Text.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
philipj_slow
PTAL
6 years, 1 month ago (2014-11-17 15:08:44 UTC) #2
pdr.
lgtm
6 years, 1 month ago (2014-11-17 16:30:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/730003003/1
6 years, 1 month ago (2014-11-17 16:31:43 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-17 16:33:50 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 185453

Powered by Google App Engine
This is Rietveld 408576698