Refactoring XSLT

Source/core/xml/DocumentXSLT.h

+#ifndef DocumentXSLT_h

[haraken, 2014/11/17 14:18:32]

Add a copyright.

[tasak, 2014/11/19 08:23:17]

Done.

+#define DocumentXSLT_h
+
+#include "core/dom/DocumentSupplementable.h"
+#include "platform/heap/Handle.h"
+#include "wtf/RefPtr.h"
+
+namespace blink {
+
+class Document;
+class EventListener;
+class ExecutionContext;
+class ProcessingInstruction;
+
+class DocumentXSLT final : public NoBaseWillBeGarbageCollected<DocumentXSLT>, public DocumentSupplement {
+public:
+    PassRefPtrWillBeRawPtr<Document> transformSourceDocument()
+    {
+        return m_transformSourceDocument;
+    }
+
+    void setTransformSourceDocument(Document* document)
+    {
+        ASSERT(document);
+        m_transformSourceDocument = document;
+    }
+
+    static DocumentXSLT& from(DocumentSupplementable&);
+    static const char* supplementName();
+
+    static PassRefPtr<EventListener> addDOMContentLoadedListenerForXSLT(Document&, ProcessingInstruction*);
+    static void applyXSLTransform(Document&, ProcessingInstruction*);
+    static ProcessingInstruction* findXSLStyleSheet(Document&);
+    static void sheetLoaded(Document&, ProcessingInstruction*);
+    static bool hasTransformSourceDocument(Document&);

[haraken, 2014/11/17 14:18:32]

We don't want to add these static methods to supplement classes. Instead, the
caller sites should call:

  DocumentXSLT::from(*document).sheetLoaded()

[tasak, 2014/11/19 08:23:17]

I added the comment:
    // The following static methods doesn't use any instance of DocumentXSLT.   
                           
    // Just they are just using DocumetnXSLT namespace. 

+
+    virtual void trace(Visitor*) override;
+
+private:
+    DocumentXSLT();
+
+    RefPtrWillBeMember<Document> m_transformSourceDocument;
+};
+
+} // namespace blink
+
+#endif