Issue 7300010: Add PPB_Memory_Dev. This is the first of a few CLs needed to pull MemAlloc and

Issue 7300010: Add PPB_Memory_Dev. This is the first of a few CLs needed to pull MemAlloc and (Closed)

Created:
9 years, 5 months ago by der Springer

Modified:
9 years, 5 months ago

Reviewers:
dmichael (off chromium), brettw

CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Add PPB_Memory_Dev. This is the first of a few CLs needed to pull MemAlloc and MemFree from PPB_Core. BUG=80610 TEST=ui_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91518

Patch Set 2 : Add missing file. #

Total comments: 4

Patch Set 3 : Add i/f to plugin_module. #

Total comments: 1

Patch Set 4 : Clean up thunk.h #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+285 lines, -0 lines)			Patch
M	chrome/test/ui/ppapi_uitest.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
A	ppapi/c/dev/ppb_memory_dev.h	View		1 chunk	+51 lines, -0 lines	0 comments	Download
A	ppapi/cpp/dev/memory_dev.h	View		1 chunk	+36 lines, -0 lines	0 comments	Download
A	ppapi/cpp/dev/memory_dev.cc	View	1	1 chunk	+33 lines, -0 lines	0 comments	Download
M	ppapi/ppapi_cpp.gypi	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	ppapi/ppapi_tests.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ppapi/tests/all_c_includes.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ppapi/tests/all_cpp_includes.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	ppapi/tests/test_memory.h	View		1 chunk	+31 lines, -0 lines	0 comments	Download
A	ppapi/tests/test_memory.cc	View	1 2	1 chunk	+57 lines, -0 lines	0 comments	Download
M	webkit/glue/webkit_glue.gypi	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/plugin_module.cc	View	1 2	3 chunks	+4 lines, -0 lines	0 comments	Download
A	webkit/plugins/ppapi/ppb_memory_impl.h	View		1 chunk	+23 lines, -0 lines	0 comments	Download
A	webkit/plugins/ppapi/ppb_memory_impl.cc	View		1 chunk	+37 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

der Springer

Out on the try bots right now. @dmichael primary reviewer @brettw FYI

9 years, 5 months ago (2011-07-01 21:27:08 UTC) #1

dmichael (off chromium)

I think you still have to update GetInterface in plugin_module.cc. http://codereview.chromium.org/7300010/diff/2001/ppapi/tests/test_memory.cc File ppapi/tests/test_memory.cc (right): http://codereview.chromium.org/7300010/diff/2001/ppapi/tests/test_memory.cc#newcode22 ...

9 years, 5 months ago (2011-07-01 21:42:10 UTC) #2

der Springer

GetInterface added. Note that I did not thunk this API, since it doesn't seem necessary. ...

9 years, 5 months ago (2011-07-05 19:28:27 UTC) #3

dmichael (off chromium)

9 years, 5 months ago (2011-07-05 19:42:36 UTC) #4

one nit, o/w LGTM

http://codereview.chromium.org/7300010/diff/6001/ppapi/thunk/thunk.h
File ppapi/thunk/thunk.h (right):

http://codereview.chromium.org/7300010/diff/6001/ppapi/thunk/thunk.h#newcode38
ppapi/thunk/thunk.h:38: struct PPB_Memory_Dev;
If you're not doing the thunk style for this, you probably shouldn't change
thunk.h in this CL

Expand Messages | Collapse Messages