Issue 7300: * StringSearch now tests aginst non-ascii needle on an ascii string as the first thing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7300: * StringSearch now tests aginst non-ascii needle on an ascii string as the first thing. (Closed)

Created:
12 years, 2 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Christian Plesner Hansen

CC:
v8-dev

Visibility:
Public.

Description

Test for non-ASCII character in a needle used on an ASCII string is now handled first instead of only in the unrelated table-construction of Boyer-Moore.

Patch Set 1 #

Patch Set 2 : Rebase to SVN version #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -16 lines)			Patch
	M	src/runtime.cc	View		4 chunks	+15 lines, -16 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

12 years, 2 months ago (2008-10-14 14:09:41 UTC) #1

Small code-review.
Untangled a check that shouldn't be bound to Boyer-Moore.
Pretty much no influence on performance of benchmarks, as they are typically
either all-ASCII or all-non-ASCII.

Expand Messages | Collapse Messages