Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 729993002: Alphabetise AcceleratorController::PerformAction() (Closed)

Created:
6 years, 1 month ago by pkotwicz
Modified:
6 years, 1 month ago
Reviewers:
oshima
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, tfarina, mazda+watch_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@nested_dispatch0
Project:
chromium
Visibility:
Public.

Description

This CL: - Alphabetises the switch statement in AcceleratorController::PerformAction() - Removes "default" from switch statement in AcceleratorController::PerformAction() - Makes several methods in AcceleratorController take AcceleratorAction instead of int as input - Rearranges methods in accelerator_controller.cc to match order in .h file BUG=404473 TEST=None R=oshima TBR=sky (For trivial addition of ifdef to chrome/browser/ui/views/accelerator_table.cc) Committed: https://crrev.com/df99bbce19ea94a0b6507f8d5a6a58d60b463741 Cr-Commit-Position: refs/heads/master@{#305066}

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+422 lines, -412 lines) Patch
M ash/accelerators/accelerator_controller.h View 5 chunks +8 lines, -7 lines 0 comments Download
M ash/accelerators/accelerator_controller.cc View 22 chunks +369 lines, -362 lines 0 comments Download
M ash/accelerators/accelerator_table.h View 5 chunks +16 lines, -17 lines 0 comments Download
M ash/accelerators/accelerator_table.cc View 1 7 chunks +21 lines, -21 lines 0 comments Download
M ash/accelerators/debug_commands.h View 2 chunks +2 lines, -1 line 0 comments Download
M ash/accelerators/debug_commands.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/accelerator_table.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
pkotwicz
Oshima, PTAL
6 years, 1 month ago (2014-11-17 16:05:43 UTC) #3
pkotwicz
Ping?
6 years, 1 month ago (2014-11-19 20:35:51 UTC) #4
oshima
hmm, I thought I lgtm'ed yesterday. lgtm
6 years, 1 month ago (2014-11-19 20:57:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/729993002/80001
6 years, 1 month ago (2014-11-20 16:27:14 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/25504)
6 years, 1 month ago (2014-11-20 16:31:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/729993002/100001
6 years, 1 month ago (2014-11-20 18:48:08 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:100001)
6 years, 1 month ago (2014-11-20 19:48:11 UTC) #14
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 19:48:58 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/df99bbce19ea94a0b6507f8d5a6a58d60b463741
Cr-Commit-Position: refs/heads/master@{#305066}

Powered by Google App Engine
This is Rietveld 408576698