Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 729973003: Mark fast/pagination/div-x-horizontal-bt-[ltr, rtl] as flaky. (Closed)

Created:
6 years, 1 month ago by andersr
Modified:
6 years, 1 month ago
CC:
blink-reviews, rune
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Mark fast/pagination/div-x-horizontal-bt-[ltr, rtl] as flaky. These two tests (and their copies in compare-with-old-impl) are all among the top ten flakes on the Blink trybots, so win_blink_rel reliability should noticably improve with this CL. The compare-with-old-impl versions have been removed, since they're no longer needed after virtual/regionbasedmulticol. Marked as flakes for Windows only, since they seem stable on other platforms. BUG=433848 R=mstensho@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185477

Patch Set 1 #

Total comments: 1

Messages

Total messages: 11 (3 generated)
andersr
6 years, 1 month ago (2014-11-17 16:01:36 UTC) #1
mstensho (USE GERRIT)
https://codereview.chromium.org/729973003/diff/1/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/729973003/diff/1/LayoutTests/TestExpectations#newcode964 LayoutTests/TestExpectations:964: crbug.com/433848 [ Win ] virtual/regionbasedmulticol/fast/pagination/div-x-horizontal-bt-ltr.html [ Pass Failure ImageOnlyFailure ...
6 years, 1 month ago (2014-11-17 16:07:46 UTC) #2
andersr
On 2014/11/17 16:07:46, mstensho wrote: > https://codereview.chromium.org/729973003/diff/1/LayoutTests/TestExpectations > File LayoutTests/TestExpectations (right): > > https://codereview.chromium.org/729973003/diff/1/LayoutTests/TestExpectations#newcode964 > ...
6 years, 1 month ago (2014-11-17 16:16:18 UTC) #3
mstensho (USE GERRIT)
ok then. lgtm.
6 years, 1 month ago (2014-11-17 19:43:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/729973003/1
6 years, 1 month ago (2014-11-17 22:42:17 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/31274)
6 years, 1 month ago (2014-11-17 23:56:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/729973003/1
6 years, 1 month ago (2014-11-18 00:31:06 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-18 01:09:47 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185477

Powered by Google App Engine
This is Rietveld 408576698