LayoutTests/http/tests/serviceworker/chromium/resources/ping-worker.js - Issue 729923004: Add some tests to make sure message ports properly queue up message.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/serviceworker/chromium/resources/ping-worker.js

Issue 729923004: Add some tests to make sure message ports properly queue up message. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cross_process_messaging_with_terminate

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/serviceworker/chromium/postmessage-after-terminate.html ('K') | « LayoutTests/http/tests/serviceworker/chromium/postmessage-after-terminate.html ('k') | LayoutTests/http/tests/serviceworker/chromium/resources/postmessage-port-worker.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/serviceworker/chromium/resources/ping-worker.js

diff --git a/LayoutTests/http/tests/serviceworker/chromium/resources/ping-worker.js b/LayoutTests/http/tests/serviceworker/chromium/resources/ping-worker.js

index 7c82c4ed55d0330f1cdc8cb3fda264f6b69f5f38..30c8e1f2e5cace44538bfd6f635aca24655cb7ea 100644

--- a/LayoutTests/http/tests/serviceworker/chromium/resources/ping-worker.js

+++ b/LayoutTests/http/tests/serviceworker/chromium/resources/ping-worker.js

@@ -1,4 +1,4 @@

-var counter = 0;

+var counter = 1;

falken 2014/11/20 04:09:29 I'm a bit lost, why is this change needed? Feels l

Marijn Kruisselbrink 2014/11/20 21:42:38 Sorry, these changes were just an incorrect merge

self.onmessage = function(event) {

falken 2014/11/20 04:09:29 Seems cleaner do to counter++; postMessage(counter

event.data.port.postMessage(counter++);

};