Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: LayoutTests/http/tests/serviceworker/chromium/resources/ping-worker.js

Issue 729923004: Add some tests to make sure message ports properly queue up message. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cross_process_messaging_with_terminate
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« LayoutTests/http/tests/serviceworker/chromium/postmessage-after-terminate.html ('K') | « LayoutTests/http/tests/serviceworker/chromium/postmessage-after-terminate.html ('k') | LayoutTests/http/tests/serviceworker/chromium/resources/postmessage-port-worker.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 var counter = 0; 1 var counter = 1;
falken 2014/11/20 04:09:29 I'm a bit lost, why is this change needed? Feels l
Marijn Kruisselbrink 2014/11/20 21:42:38 Sorry, these changes were just an incorrect merge
2 self.onmessage = function(event) { 2 self.onmessage = function(event) {
falken 2014/11/20 04:09:29 Seems cleaner do to counter++; postMessage(counter
3 event.data.port.postMessage(counter++); 3 event.data.port.postMessage(counter++);
4 }; 4 };
OLDNEW
« LayoutTests/http/tests/serviceworker/chromium/postmessage-after-terminate.html ('K') | « LayoutTests/http/tests/serviceworker/chromium/postmessage-after-terminate.html ('k') | LayoutTests/http/tests/serviceworker/chromium/resources/postmessage-port-worker.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698