Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 729913004: Add a html-based visualizer for TurboFan graphs (Closed)

Created:
6 years, 1 month ago by danno
Modified:
4 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add a html-based visualizer for TurboFan graphs Committed: https://crrev.com/9c15c055966b670058d1bfd73bdbadf4fb1ae3ae Cr-Commit-Position: refs/heads/master@{#36351}

Patch Set 1 : #

Patch Set 2 : Latest changes #

Patch Set 3 : JSON escaped stream #

Patch Set 4 : Latest #

Patch Set 5 : Milestone #

Patch Set 6 : Better code selection #

Patch Set 7 : Source selection #

Patch Set 8 : Add working source view #

Patch Set 9 : Latest version #

Patch Set 10 : Latest #

Patch Set 11 : Latest #

Patch Set 12 : Latest #

Patch Set 13 : Latest #

Patch Set 14 : Fix urls #

Patch Set 15 : Iterate #

Patch Set 16 : latest #

Patch Set 17 : Latest #

Patch Set 18 : Turbolizer! #

Patch Set 19 : Add node searching #

Patch Set 20 : Support displaying types #

Patch Set 21 : Rebase #

Patch Set 22 : Latest #

Patch Set 23 : Latest #

Patch Set 24 : Fix type display #

Patch Set 25 : Remove extra copy #

Patch Set 26 : Latest version #

Patch Set 27 : Latest, including disassembly view #

Total comments: 2

Patch Set 28 : Review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3322 lines, -0 lines) Patch
A tools/turbolizer/OWNERS View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 1 chunk +1 line, -0 lines 0 comments Download
A tools/turbolizer/README View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 1 chunk +20 lines, -0 lines 0 comments Download
A tools/turbolizer/code-view.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 1 chunk +177 lines, -0 lines 0 comments Download
A tools/turbolizer/constants.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 1 chunk +22 lines, -0 lines 0 comments Download
A tools/turbolizer/disassembly-view.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 1 chunk +106 lines, -0 lines 0 comments Download
A tools/turbolizer/edge.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +77 lines, -0 lines 0 comments Download
A tools/turbolizer/empty-view.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 1 chunk +19 lines, -0 lines 0 comments Download
A tools/turbolizer/expand-all.jpg View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 24 25 Binary file 0 comments Download
A tools/turbolizer/graph-layout.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +474 lines, -0 lines 0 comments Download
A tools/turbolizer/graph-view.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 1 chunk +860 lines, -0 lines 0 comments Download
A tools/turbolizer/hide-selected.png View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 24 25 Binary file 0 comments Download
A tools/turbolizer/hide-unselected.png View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 24 25 Binary file 0 comments Download
A tools/turbolizer/index.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 1 chunk +88 lines, -0 lines 0 comments Download
A tools/turbolizer/lang-disassembly.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +14 lines, -0 lines 0 comments Download
A tools/turbolizer/layout-icon.png View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 24 25 Binary file 0 comments Download
A tools/turbolizer/left-arrow.png View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 24 25 Binary file 0 comments Download
A tools/turbolizer/monkey.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +26 lines, -0 lines 0 comments Download
A tools/turbolizer/node.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +138 lines, -0 lines 0 comments Download
A tools/turbolizer/right-arrow.png View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 24 25 Binary file 0 comments Download
A tools/turbolizer/schedule-view.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 1 chunk +108 lines, -0 lines 0 comments Download
A tools/turbolizer/search.png View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 24 25 Binary file 0 comments Download
A tools/turbolizer/search2.png View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 Binary file 0 comments Download
A tools/turbolizer/selection.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +98 lines, -0 lines 0 comments Download
A tools/turbolizer/selection-broker.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +46 lines, -0 lines 0 comments Download
A tools/turbolizer/text-view.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 1 chunk +394 lines, -0 lines 0 comments Download
A tools/turbolizer/turbo-visualizer.css View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 1 chunk +326 lines, -0 lines 0 comments Download
A tools/turbolizer/turbo-visualizer.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 1 chunk +215 lines, -0 lines 0 comments Download
A tools/turbolizer/types.png View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 24 25 Binary file 0 comments Download
A tools/turbolizer/upload-icon.png View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 24 25 Binary file 0 comments Download
A tools/turbolizer/util.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 1 chunk +71 lines, -0 lines 0 comments Download
A tools/turbolizer/view.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
danno
PTAL. I almost accidentally deleted my local copy, so although I'm still pretty ashamed of ...
4 years, 7 months ago (2016-05-12 10:33:04 UTC) #5
dingding
On 2016/05/12 10:33:04, danno wrote: > PTAL. I almost accidentally deleted my local copy, so ...
4 years, 7 months ago (2016-05-12 17:19:06 UTC) #6
danno
On 2016/05/12 17:19:06, dingding wrote: > On 2016/05/12 10:33:04, danno wrote: > > PTAL. I ...
4 years, 7 months ago (2016-05-12 20:47:34 UTC) #7
danno
4 years, 7 months ago (2016-05-12 20:48:01 UTC) #9
Michael Starzinger
LGTM (rubber-stamped). https://codereview.chromium.org/729913004/diff/580001/tools/turbolizer/README File tools/turbolizer/README (right): https://codereview.chromium.org/729913004/diff/580001/tools/turbolizer/README#newcode1 tools/turbolizer/README:1: Graph visualization and manipulation based on Mike ...
4 years, 7 months ago (2016-05-13 08:14:18 UTC) #10
danno
Addressed feedback, landing.
4 years, 7 months ago (2016-05-19 07:46:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/729913004/600001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/729913004/600001
4 years, 7 months ago (2016-05-19 07:47:07 UTC) #14
commit-bot: I haz the power
Committed patchset #28 (id:600001)
4 years, 7 months ago (2016-05-19 08:17:35 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 08:18:12 UTC) #17
Message was sent while issue was closed.
Patchset 28 (id:??) landed as
https://crrev.com/9c15c055966b670058d1bfd73bdbadf4fb1ae3ae
Cr-Commit-Position: refs/heads/master@{#36351}

Powered by Google App Engine
This is Rietveld 408576698