Issue 7299: * Split the BoyerMooreStringSearch function into more separate functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7299: * Split the BoyerMooreStringSearch function into more separate functions. (Closed)

Created:
12 years, 2 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Visibility:
Public.

Description

The BoyerMooreStringSearch now uses separate functions to build its tables. This hightens readability.

Patch Set 1 #

Patch Set 2 : Separated BoyerMoore into more functions #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -60 lines)			Patch
	M	src/runtime.cc	View	1	3 chunks	+78 lines, -60 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

12 years, 2 months ago (2008-10-14 13:14:14 UTC) #2

LGTM

http://codereview.chromium.org/7299/diff/1/2
File src/runtime.cc (right):

http://codereview.chromium.org/7299/diff/1/2#newcode1042
Line 1042: // no suffix to extend, so we check against last_char only.
no -> No

Expand Messages | Collapse Messages