Issue 729853005: Generalize ScaledWithOffsetMatcher to support 64 bits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 729853005: Generalize ScaledWithOffsetMatcher to support 64 bits (Closed)

Created:
6 years, 1 month ago by danno

Modified:
6 years, 1 month ago

Reviewers:
Benedikt Meurer, titzer

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

Generalize ScaledWithOffsetMatcher to support 64 bits Preparation for supporting more addressing modes in instruction selection. R=bmeurer@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/f173937cdfb089b7265b4735668438f4666ec410

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+477 lines, -135 lines)			Patch
M	src/compiler/node-matchers.h	View		11 chunks	+70 lines, -31 lines	0 comments	Download
M	src/compiler/x64/instruction-selector-x64.cc	View	1	2 chunks	+7 lines, -4 lines	0 comments	Download
M	test/unittests/compiler/node-matchers-unittest.cc	View		5 chunks	+400 lines, -100 lines	0 comments	Download

Total messages: 4 (1 generated)

danno

6 years, 1 month ago (2014-11-17 10:53:35 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
f173937cdfb089b7265b4735668438f4666ec410 (presubmit successful).