MIPS: Handle all object types (minus smi) in load/store ICs.

MIPS: Handle all object types (minus smi) in load/store ICs.

Port r17755 (bfef904)

BUG=

[Paul Lind, 2013-11-14 19:13:04]

Need to fix the b() branches, as they are incorrect in this usage, see comments.

https://codereview.chromium.org/72983002/diff/1/src/mips/stub-cache-mips.cc
File src/mips/stub-cache-mips.cc (right):

https://codereview.chromium.org/72983002/diff/1/src/mips/stub-cache-mips.cc#n...
src/mips/stub-cache-mips.cc:1293: __ b(&success);
This is a mistake, b() is a raw branch with delay slot exposed, which I don't
think you want here.
Suggest you use Branch(&success);, but jmp(&label would also work.

https://codereview.chromium.org/72983002/diff/1/src/mips/stub-cache-mips.cc#n...
src/mips/stub-cache-mips.cc:1304: __ b(&success);
Use Branch() (we used b() before here, which was wrong, and we must have been
lucky with the delay slot.)

https://codereview.chromium.org/72983002/diff/1/src/mips/stub-cache-mips.cc#n...
src/mips/stub-cache-mips.cc:2655: __ b(&success);
Use Branch()

[kilvadyb, 2013-11-14 20:04:29]

https://codereview.chromium.org/72983002/diff/1/src/mips/stub-cache-mips.cc
File src/mips/stub-cache-mips.cc (right):

https://codereview.chromium.org/72983002/diff/1/src/mips/stub-cache-mips.cc#n...
src/mips/stub-cache-mips.cc:1293: __ b(&success);
On 2013/11/14 19:13:04, Paul Lind wrote:
> This is a mistake, b() is a raw branch with delay slot exposed, which I don't
> think you want here.
> Suggest you use Branch(&success);, but jmp(&label would also work.

Done.

https://codereview.chromium.org/72983002/diff/1/src/mips/stub-cache-mips.cc#n...
src/mips/stub-cache-mips.cc:1304: __ b(&success);
On 2013/11/14 19:13:04, Paul Lind wrote:
> Use Branch() (we used b() before here, which was wrong, and we must have been
> lucky with the delay slot.)

Done.

https://codereview.chromium.org/72983002/diff/1/src/mips/stub-cache-mips.cc#n...
src/mips/stub-cache-mips.cc:2655: __ b(&success);
On 2013/11/14 19:13:04, Paul Lind wrote:
> Use Branch()

Done.

[Paul Lind, 2013-11-14 20:32:08]

lgtm

[Paul Lind, 2013-11-14 20:36:25]

Committed as r17762.