Easy Sign-in: Use TPM RSA key to sign nonce in sign-in protocol

chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.cc

Index: chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.cc
diff --git a/chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.cc b/chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.cc
new file mode 100644
index 0000000000000000000000000000000000000000..943d1d60501da61003eb89b0fc3257b0a7367b5a
--- /dev/null
+++ b/chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.cc
@@ -0,0 +1,342 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.h"
+
+#include <cryptohi.h>
+
+#include "base/base64.h"
+#include "base/bind.h"
+#include "base/location.h"
+#include "base/logging.h"
+#include "base/memory/ref_counted.h"
+#include "base/prefs/pref_registry_simple.h"
+#include "base/prefs/pref_service.h"
+#include "base/prefs/scoped_user_pref_update.h"
+#include "base/single_thread_task_runner.h"
+#include "base/thread_task_runner_handle.h"
+#include "base/threading/worker_pool.h"
+#include "base/time/time.h"
+#include "base/values.h"
+#include "chrome/browser/browser_process.h"
+#include "chrome/common/pref_names.h"
+#include "content/public/browser/browser_thread.h"
+#include "crypto/nss_util_internal.h"
+#include "crypto/rsa_private_key.h"
+#include "crypto/scoped_nss_types.h"
+
+namespace {
+
+// The modulus length for RSA keys used by easy sign-in.
+const int kKeyModulusLength = 2048;
+
+// Relays |GetSystemSlotOnIOThread| callback to |response_task_runner|.
+void RunCallbackOnThreadRunner(
+    const scoped_refptr<base::SingleThreadTaskRunner>& response_task_runner,
+    const base::Callback<void(crypto::ScopedPK11Slot)>& callback,
+    crypto::ScopedPK11Slot slot) {
+  response_task_runner->PostTask(FROM_HERE,
+                                 base::Bind(callback, base::Passed(&slot)));
+}
+
+// Gets TPM system slot. Must be called on IO thread.
+// The callback wil be relayed to |response_task_runner|.
+void GetSystemSlotOnIOThread(
+    const scoped_refptr<base::SingleThreadTaskRunner>& response_task_runner,
+    const base::Callback<void(crypto::ScopedPK11Slot)>& callback) {
+  base::Callback<void(crypto::ScopedPK11Slot)> callback_on_origin_thread =
+      base::Bind(&RunCallbackOnThreadRunner, response_task_runner, callback);
+
+  crypto::ScopedPK11Slot system_slot =
+      crypto::GetSystemNSSKeySlot(callback_on_origin_thread);
+  if (system_slot)
+    callback_on_origin_thread.Run(system_slot.Pass());
+}
+
+// Checks if a private RSA key associated with |public_key| can be found in
+// |slot|.
+// Must be called on a worker thread.
+scoped_ptr<crypto::RSAPrivateKey> GetPrivateKeyOnWorkerThread(
+    PK11SlotInfo* slot,
+    const std::string& public_key) {
+  const uint8* public_key_uint8 =
+      reinterpret_cast<const uint8*>(public_key.data());
+  std::vector<uint8> public_key_vector(
+      public_key_uint8, public_key_uint8 + public_key.size());
+
+  scoped_ptr<crypto::RSAPrivateKey> rsa_key(
+      crypto::RSAPrivateKey::FindFromPublicKeyInfo(public_key_vector));
+  if (!rsa_key || rsa_key->key()->pkcs11Slot != slot)
+    return scoped_ptr<crypto::RSAPrivateKey>();
+  return rsa_key.Pass();
+}
+
+// Signs |data| using a private key associated with |public_key| and stored in
+// |slot|. Once the data is signed, callback is run on |response_task_runner|.
+// In case of an error, the callback will be passed an empty string.
+void SignDataOnWorkerThread(
+    crypto::ScopedPK11Slot slot,
+    const std::string& public_key,
+    const std::string& data,
+    const scoped_refptr<base::SingleThreadTaskRunner>& response_task_runner,
+    const base::Callback<void(const std::string&)>& callback) {
+  scoped_ptr<crypto::RSAPrivateKey> private_key(
+      GetPrivateKeyOnWorkerThread(slot.get(), public_key));
+  if (!private_key) {
+    LOG(ERROR) << "Private key for signing data not found";
+    response_task_runner->PostTask(FROM_HERE,
+                                   base::Bind(callback, std::string()));
+    return;
+  }
+
+  SECItem sign_result = {siBuffer, NULL, 0};
+  if (SEC_SignData(&sign_result,
+                   reinterpret_cast<const unsigned char*>(data.data()),
+                   data.size(),
+                   private_key->key(),
+                   SEC_OID_PKCS1_SHA256_WITH_RSA_ENCRYPTION) != SECSuccess) {
+    LOG(ERROR) << "Failed to sign data";
+    response_task_runner->PostTask(FROM_HERE,
+                                   base::Bind(callback, std::string()));
+    return;
+  }
+
+  std::string signature(reinterpret_cast<const char*>(sign_result.data),
+                        sign_result.len);
+  response_task_runner->PostTask(FROM_HERE, base::Bind(callback, signature));
+}
+
+// Creates a RSA key pair in |slot|. When done, it runs |callback| with the
+// created public key on |response_task_runner|.
+// If |public_key| is not empty, a key pair will be created only if the private
+// key associated with |public_key| does not exist in |slot|. Otherwise the
+// callback will be run with |public_key|.
+void CreateTpmKeyPairOnWorkerThread(
+    crypto::ScopedPK11Slot slot,
+    const std::string& public_key,
+    const scoped_refptr<base::SingleThreadTaskRunner>& response_task_runner,
+    const base::Callback<void(const std::string&)>& callback) {
+  if (!public_key.empty() &&
+      GetPrivateKeyOnWorkerThread(slot.get(), public_key)) {
+    response_task_runner->PostTask(FROM_HERE, base::Bind(callback, public_key));
+    return;
+  }
+
+  scoped_ptr<crypto::RSAPrivateKey> rsa_key(
+      crypto::RSAPrivateKey::CreateSensitive(slot.get(), kKeyModulusLength));
+  if (!rsa_key) {
+    LOG(ERROR) << "Failed to create an RSA key.";
+    response_task_runner->PostTask(FROM_HERE,
+                                   base::Bind(callback, std::string()));
+    return;
+  }
+
+  std::vector<uint8> created_public_key;
+  if (!rsa_key->ExportPublicKey(&created_public_key)) {
+    LOG(ERROR) << "Failed to export public key.";
+    response_task_runner->PostTask(FROM_HERE,
+                                   base::Bind(callback, std::string()));
+    return;
+  }
+
+  response_task_runner->PostTask(
+      FROM_HERE,
+      base::Bind(callback,
+                 std::string(created_public_key.begin(),
+                             created_public_key.end())));
+}
+
+}  // namespace
+
+// static
+void EasyUnlockTpmKeyManager::RegisterLocalStatePrefs(
+    PrefRegistrySimple* registry) {
+  registry->RegisterDictionaryPref(prefs::kEasyUnlockLocalStateTpmKeys);
+}
+
+// static
+void EasyUnlockTpmKeyManager::ResetLocalStateForUser(
+    const std::string& user_id) {
+  if (!g_browser_process)
+    return;
+  PrefService* local_state = g_browser_process->local_state();
+  if (!local_state)
+    return;
+
+  DictionaryPrefUpdate update(local_state, prefs::kEasyUnlockLocalStateTpmKeys);
+  update->RemoveWithoutPathExpansion(user_id, NULL);
+}
+
+EasyUnlockTpmKeyManager::EasyUnlockTpmKeyManager(const std::string& user_id,
+                                                 PrefService* local_state)
+    : user_id_(user_id),
+      local_state_(local_state),
+      creating_tpm_key_pair_(false),
+      got_tpm_slot_(false),
+      get_tpm_slot_weak_ptr_factory_(this),
+      weak_ptr_factory_(this) {
+}
+
+EasyUnlockTpmKeyManager::~EasyUnlockTpmKeyManager() {
+}
+
+bool EasyUnlockTpmKeyManager::PrepareTpmKey(
+    const std::string& user_id,
+    bool check_private_key,
+    const base::Closure& callback) {
+  CHECK(!user_id_.empty());
+  CHECK_EQ(user_id_, user_id);
+
+  std::string key = GetPublicTpmKey(user_id);
+  if (!check_private_key && !creating_tpm_key_pair_ && !key.empty())
+    return true;
+
+  tpm_key_present_callbacks_.push_back(callback);
+  if (!creating_tpm_key_pair_) {
+    creating_tpm_key_pair_ = true;
+
+    base::Callback<void(crypto::ScopedPK11Slot)> create_key_with_system_slot =
+        base::Bind(&EasyUnlockTpmKeyManager::CreateKeyInSystemSlot,
+                   get_tpm_slot_weak_ptr_factory_.GetWeakPtr(),
+                   user_id,
+                   key);
+
+    content::BrowserThread::PostTask(
+        content::BrowserThread::IO,
+        FROM_HERE,
+        base::Bind(&GetSystemSlotOnIOThread,
+                   base::ThreadTaskRunnerHandle::Get(),
+                   create_key_with_system_slot));
+  }
+
+  return false;
+}
+
+bool EasyUnlockTpmKeyManager::SetGetSystemSlotTimeoutMs(size_t timeout_ms) {

[pneubeck (no reviews), 2014/12/05 12:16:04]

SetTimeout sounds like you would set the timeout duration but not actually
starting the timeout.
Maybe call it Start.*Timeout ?

[pneubeck (no reviews), 2014/12/05 12:16:04]

it seems to be invalid/uneffective if this is called before PerpareTpmKey, is it
worth checking that?

[tbarzic, 2014/12/11 23:43:27]

Done.

[tbarzic, 2014/12/11 23:43:28]

Hm, it should still be effective if it's called just before PrepareTpmKey,
though the timeout would be shorter (in respect to PrepareTpmKey start).
I'm not really sure this is worth checking, though.

+  if (got_tpm_slot_)
+    return false;
+
+  base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(
+      FROM_HERE,
+      base::Bind(&EasyUnlockTpmKeyManager::OnTpmKeyCreated,
+                 get_tpm_slot_weak_ptr_factory_.GetWeakPtr(),
+                 user_id_,
+                 std::string()),
+      base::TimeDelta::FromMilliseconds(timeout_ms));
+  return true;
+}
+
+std::string EasyUnlockTpmKeyManager::GetPublicTpmKey(
+    const std::string& user_id) {
+  if (!local_state_)
+    return std::string();
+  const base::DictionaryValue* dict =
+      local_state_->GetDictionary(prefs::kEasyUnlockLocalStateTpmKeys);
+  std::string key;
+  if (dict)
+    dict->GetStringWithoutPathExpansion(user_id, &key);
+  std::string decoded;
+  base::Base64Decode(key, &decoded);
+  return decoded;
+}
+
+void EasyUnlockTpmKeyManager::SignUsingTpmKey(
+    const std::string& user_id,
+    const std::string& data,
+    const base::Callback<void(const std::string& data)> callback) {
+  std::string key = GetPublicTpmKey(user_id);
+  if (key.empty()) {
+    callback.Run(std::string());
+    return;
+  }
+
+  base::Callback<void(crypto::ScopedPK11Slot)> sign_with_system_slot =
+      base::Bind(&EasyUnlockTpmKeyManager::SignDataWithSystemSlot,
+                 weak_ptr_factory_.GetWeakPtr(),
+                 key, data, callback);
+
+  content::BrowserThread::PostTask(
+      content::BrowserThread::IO,
+      FROM_HERE,
+      base::Bind(&GetSystemSlotOnIOThread,
+                 base::ThreadTaskRunnerHandle::Get(),
+                 sign_with_system_slot));
+}
+
+void EasyUnlockTpmKeyManager::SetKeyInLocalState(const std::string& user_id,
+                                                 const std::string& value) {
+  if (!local_state_)
+    return;
+
+  std::string encoded;
+  base::Base64Encode(value, &encoded);
+  DictionaryPrefUpdate update(local_state_,
+                              prefs::kEasyUnlockLocalStateTpmKeys);
+  update->SetStringWithoutPathExpansion(user_id, encoded);
+}
+
+void EasyUnlockTpmKeyManager::CreateKeyInSystemSlot(
+    const std::string& user_id,
+    const std::string& public_key,
+    crypto::ScopedPK11Slot system_slot) {
+  CHECK(system_slot);
+
+  got_tpm_slot_ = true;
+  get_tpm_slot_weak_ptr_factory_.InvalidateWeakPtrs();

[pneubeck (no reviews), 2014/12/05 12:16:04]

probably document what effect this should have. Currently it aborts silently
both any other pending CreateKeyInSystemSlot and any Timeout.

[tbarzic, 2014/12/11 23:43:27]

Done.

+
+  base::WorkerPool::PostTask(
+      FROM_HERE,
+      base::Bind(&CreateTpmKeyPairOnWorkerThread,

[pneubeck (no reviews), 2014/12/05 12:16:04]

what if this hangs? why does the timeout not skip waiting for this task as well?

[tbarzic, 2014/12/11 23:43:27]

My main concern is with GetSystemSlot hanging indefinitely during login (if
there are user flags set, we'll wait for PrepareTpmKey to finish before
proceeding; good news is that under these circumstances in the vast majority of
cases PrepareTpmKey should return synchronously, without actually loading the
system slot).

+                 base::Passed(&system_slot),
+                 public_key,
+                 base::ThreadTaskRunnerHandle::Get(),
+                 base::Bind(&EasyUnlockTpmKeyManager::OnTpmKeyCreated,
+                            weak_ptr_factory_.GetWeakPtr(),
+                            user_id)),
+      true /* long task */);
+}
+
+void EasyUnlockTpmKeyManager::SignDataWithSystemSlot(
+    const std::string& public_key,
+    const std::string& data,
+    const base::Callback<void(const std::string& data)> callback,
+    crypto::ScopedPK11Slot system_slot) {
+  CHECK(system_slot);
+
+  base::WorkerPool::PostTask(
+      FROM_HERE,
+      base::Bind(&SignDataOnWorkerThread,
+                 base::Passed(&system_slot),
+                 public_key,
+                 data,
+                 base::ThreadTaskRunnerHandle::Get(),
+                 base::Bind(&EasyUnlockTpmKeyManager::OnDataSigned,
+                            weak_ptr_factory_.GetWeakPtr(),
+                            callback)),
+      true /* long task */);
+}
+
+void EasyUnlockTpmKeyManager::OnTpmKeyCreated(
+    const std::string& user_id,
+    const std::string& public_key) {
+  creating_tpm_key_pair_ = false;
+
+  get_tpm_slot_weak_ptr_factory_.InvalidateWeakPtrs();

[pneubeck (no reviews), 2014/12/05 12:16:04]

same comment as in line 286

[tbarzic, 2014/12/11 23:43:27]

Done.

+
+  if (!public_key.empty())
+    SetKeyInLocalState(user_id, public_key);
+
+  for (size_t i = 0; i < tpm_key_present_callbacks_.size(); ++i) {
+    if (!tpm_key_present_callbacks_[i].is_null())
+      tpm_key_present_callbacks_[i].Run();
+  }
+
+  tpm_key_present_callbacks_.clear();
+}
+
+void EasyUnlockTpmKeyManager::OnDataSigned(
+    const base::Callback<void(const std::string&)>& callback,
+    const std::string& signature) {
+  callback.Run(signature);
+}