Issue 7297: * Added badness-check to trigger computation of good-suffix table in Boyer-Moore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7297: * Added badness-check to trigger computation of good-suffix table in Boyer-Moore. (Closed)

Created:
12 years, 2 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Visibility:
Public.

Description

Boyer-Moore delayes computation of Good-Suffix table until bad-char has shown itself to be insufficient.x Changed order of tests in loop in simple text search. Changed limit on pattern length for when we pick simple search.

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -58 lines)			Patch
	M	src/runtime.cc	View		3 chunks	+89 lines, -58 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

12 years, 2 months ago (2008-10-14 12:42:05 UTC) #2

LGTM with comments

http://codereview.chromium.org/7297/diff/1/2
File src/runtime.cc (right):

http://codereview.chromium.org/7297/diff/1/2#newcode1001
Line 1001: static int BoyerMooreIndexOf(Vector<const schar> subject,
This function is too big now.  It has to be split up.  I would suggest:

BuildBadCharTable
BoyerMooreHorspool
BuildSuffixTable
BoyerMoore

Expand Messages | Collapse Messages