Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 7297: * Added badness-check to trigger computation of good-suffix table in Boyer-Moore. (Closed)

Created:
12 years, 2 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Boyer-Moore delayes computation of Good-Suffix table until bad-char has shown itself to be insufficient.x Changed order of tests in loop in simple text search. Changed limit on pattern length for when we pick simple search.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -58 lines) Patch
M src/runtime.cc View 3 chunks +89 lines, -58 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein
Small code review.
12 years, 2 months ago (2008-10-14 12:28:51 UTC) #1
Erik Corry
12 years, 2 months ago (2008-10-14 12:42:05 UTC) #2
LGTM with comments

http://codereview.chromium.org/7297/diff/1/2
File src/runtime.cc (right):

http://codereview.chromium.org/7297/diff/1/2#newcode1001
Line 1001: static int BoyerMooreIndexOf(Vector<const schar> subject,
This function is too big now.  It has to be split up.  I would suggest:

BuildBadCharTable
BoyerMooreHorspool
BuildSuffixTable
BoyerMoore

Powered by Google App Engine
This is Rietveld 408576698