First step at getting rid of anonymous blocks and continuations.

First step at getting rid of anonymous blocks and continuations.

-Add RenderParagraph and display:paragraph. This is the only
render type that's allowed to contain inlines or text.
-If you put text nodes directly in a non-paragraph, wrap them
in an anonymous paragraph. This may not be the place we want
to end up, but it's a good stopgap to make it so we don't
crash in this case.
-Make StyleAdjuster force that non-paragraph blocks only contain
RenderBlock subclasses and that paragraphs and inlines only contain
inlines.
-Considerably simplify addChildIgnoringAnonymousColumnBlocks
now that we only create anonymous blocks for the case of
text nodes in non-paragraphs. Also get rid of the behavior
where we try to group multiple nodes into a single
anonymous block.

R=esprehn@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/f8bae4e0a89b2be24df547d35d01ea05580e2ec4

[ojan, 2014-11-15 03:47:41]

ojan@chromium.org changed reviewers:
+ eseidel@chromium.org, esprehn@chromium.org

[ojan, 2014-11-15 03:47:41]

There's a couple open questions that can be handled in a followup set of
patches:
1. What should happen if you put a text node inside a non-paragraph? We can't
coerce the text node into having style and display (although maybe we should?).
For now I wrapped it in an anonymous block so we wouldn't crash. Not sure what
we want to do long-term. I don't do any coalescing though. If there are two text
nodes next to each other, you'll get two anonymous blocks. It's almost as if
they're elements.
2. What should happen when you put a paragraph inside an inline? Should it be
like and inline or do we need to add display:inline-paragraph? I guess this
problem will go away entirely when we get rid of display and only have display
control how your children layout. So...I guess that's not an open question.

This is just the first pass. After this lands:
1. There's a ton of effectively dead code after this since continuations are
impossible and anonymous blocks are considerably simplified.
2. Also, there's no concept of childrenInline in RenderBlock anymore. I'll need
to split up RenderBlockFlow into something that does block layout and moving all
the inline bits into RenderParagraph, then have RenderParagraph inherit from
RenderBlock instead.

[esprehn, 2014-11-18 00:20:02]

lgtm w/ nits. It looks like you totally busted the flights app? Can you fix it
after landing?

https://codereview.chromium.org/729693003/diff/40001/sky/engine/core/renderin...
File sky/engine/core/rendering/RenderParagraph.h (right):

https://codereview.chromium.org/729693003/diff/40001/sky/engine/core/renderin...
sky/engine/core/rendering/RenderParagraph.h:15: class RenderParagraph : public
RenderBlockFlow {
final

https://codereview.chromium.org/729693003/diff/40001/sky/engine/core/renderin...
sky/engine/core/rendering/RenderParagraph.h:20: static RenderParagraph*
createAnonymous(Document*);
take a reference.

[ojan, 2014-11-18 02:39:37]

On 2014/11/18 at 00:20:02, esprehn wrote:
> lgtm w/ nits. It looks like you totally busted the flights app? Can you fix it
after landing?

Nope. It's working fine. The diff is just confusing. It's the same as the other
tests. text nodes directly inside display:block sections are now getting an
anonymous wrapper. We'll need to figure out what the right thing to do in that
case. Creating all these anonymous wrappers is crazy. But it's good enough for
making incremental progress.

https://codereview.chromium.org/729693003/diff/40001/sky/engine/core/renderin...
File sky/engine/core/rendering/RenderParagraph.h (right):

https://codereview.chromium.org/729693003/diff/40001/sky/engine/core/renderin...
sky/engine/core/rendering/RenderParagraph.h:15: class RenderParagraph : public
RenderBlockFlow {
On 2014/11/18 at 00:20:02, esprehn wrote:
> final

done

https://codereview.chromium.org/729693003/diff/40001/sky/engine/core/renderin...
sky/engine/core/rendering/RenderParagraph.h:20: static RenderParagraph*
createAnonymous(Document*);
On 2014/11/18 at 00:20:02, esprehn wrote:
> take a reference.

done

[ojan, 2014-11-18 02:39:57]

Committed patchset #4 (id:60001) manually as
f8bae4e0a89b2be24df547d35d01ea05580e2ec4.

[jamesr, 2014-11-18 06:34:58]

jamesr@chromium.org changed reviewers:
+ jamesr@chromium.org

[jamesr, 2014-11-18 06:34:58]

FAILED: /b/build/goma/gomacc
../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++
-MMD -MF obj/sky/engine/core/css/resolver/libsky_core.StyleAdjuster.o.d
-DCHROMIUM_BUILD -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=1
-DENABLE_NOTIFICATIONS -DENABLE_BROWSER_CDMS -DENABLE_PRINTING=1
-DENABLE_BASIC_PRINTING=1 -DUSE_OPENSSL=1 -DUSE_OPENSSL_CERTS=1 -DNO_TCMALLOC
-DDISABLE_NACL -DENABLE_CONFIGURATION_POLICY -DENABLE_MANAGED_USERS=1
-DENABLE_AUTOFILL_DIALOG=1 -D_FILE_OFFSET_BITS=64 -DANDROID -DHAVE_SYS_UIO_H
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DUSE_STLPORT=1
-D_STLP_USE_PTR_SPECIALIZATIONS=1 -D__GNU_SOURCE=1 -DNDEBUG
-DSK_SUPPORT_LEGACY_TEXTRENDERMODE -DSK_IGNORE_GPU_LAYER_HOISTING
-DSK_ENABLE_INST_COUNT=0 -DGR_GL_CUSTOM_SETUP_HEADER=\"GrGLConfig_chrome.h\"
-DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1
-DGR_GL_IGNORE_ES3_MSAA=0 -DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT
-DSK_SUPPORT_LEGACY_GETTOTALCLIP -DSK_SUPPORT_GPU=1 -DSK_USE_POSIX_THREADS
-DSK_BUILD_FOR_ANDROID -DUSE_CHROMIUM_SKIA -DENABLE_OPENTYPE_VERTICAL=1
-DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION
-DCHROME_PNG_WRITE_SUPPORT -DPNG_USER_CONFIG -DCHROME_PNG_READ_PACK_SUPPORT
-DBLINK_IMPLEMENTATION=1 -DINSIDE_BLINK -I../.. -Igen
-I../../third_party/khronos -I../../gpu -I../../v8/include -I../../skia/config
-I../../skia/ext -I../../third_party/skia/include/c
-I../../third_party/skia/include/config -I../../third_party/skia/include/core
-I../../third_party/skia/include/effects -I../../third_party/skia/include/images
-I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops
-I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe
-I../../third_party/skia/include/ports -I../../third_party/skia/include/utils
-I../../third_party/skia/src/core -I../../third_party/skia/src/image
-I../../third_party/skia/src/opts -I../../third_party/skia/src/ports
-I../../third_party/skia/src/sfnt -I../../third_party/skia/src/utils
-I../../third_party/skia/src/lazy -I../../third_party/skia/include/gpu
-I../../third_party/skia/src/gpu -I../../third_party/icu/source/common
-I../../third_party/icu/source/i18n -I../../third_party/angle/include
-I../../third_party/iccjpeg -I../../third_party/libpng -I../../third_party/zlib
-I../../third_party/ots/include -I../../third_party/qcms/src -I../../sky/engine
-Igen/sky -fno-strict-aliasing -march=armv7-a -mfloat-abi=softfp
-mtune=generic-armv7-a -mthumb -mthumb-interwork -fno-tree-sra -fno-caller-saves
-funwind-tables -fPIC -pipe -ffunction-sections -funwind-tables -fno-short-enums
-finline-limit=64 -mfpu=vfpv3-d16 -Wall -Wsign-compare -Wendif-labels -Werror
-Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wno-extra
-Wno-ignored-qualifiers -Wno-type-limits -Wno-unused-local-typedefs
-isystem../../third_party/android_tools/ndk/sources/cxx-stl/stlport/stlport
-fvisibility=hidden
--sysroot=/b/build/slave/mojo/build/src/third_party/android_tools/ndk/platforms/android-14/arch-arm
-fno-ident -fdata-sections -ffunction-sections -fomit-frame-pointer -Os -g2
-Wno-unused-but-set-variable -fno-threadsafe-statics -fvisibility-inlines-hidden
-std=gnu++11 -Wno-narrowing -Wno-literal-suffix -Wno-error=c++0x-compat
-Wno-non-virtual-dtor -Wno-sign-promo -fno-rtti -fno-exceptions
-Wno-c++0x-compat -c ../../sky/engine/core/css/resolver/StyleAdjuster.cpp -o
obj/sky/engine/core/css/resolver/libsky_core.StyleAdjuster.o
../../sky/engine/core/css/resolver/StyleAdjuster.cpp: In function 'bool
blink::requiresOnlyBlockChildren(blink::RenderStyle*)':
../../sky/engine/core/css/resolver/StyleAdjuster.cpp:61:1: error: control
reaches end of non-void function [-Werror=return-type]
 }
 ^

on the android builders