Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: tools/perf/metrics/webrtc_stats.py

Issue 729643003: Relax an overly sensentive check in webrtc_stats.py. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/metrics/webrtc_stats.py
diff --git a/tools/perf/metrics/webrtc_stats.py b/tools/perf/metrics/webrtc_stats.py
index c1995773283c007e56356d1e3586a7267981c042..e6704ba773025c3361793a2fe558deb333db94c5 100644
--- a/tools/perf/metrics/webrtc_stats.py
+++ b/tools/perf/metrics/webrtc_stats.py
@@ -30,7 +30,8 @@ INTERESTING_METRICS = {
# TODO(phoglund): Add much more interesting metrics.
}
-
+# 'unknown' could return when BWE or Connection report reuse existing metric
phoglund_chromium 2014/11/17 12:29:32 Move this comment to above the return 'unknown' st
+# names which are moung INTERESTING_METRICS
def GetReportKind(report):
if 'audioInputLevel' in report or 'audioOutputLevel' in report:
return 'audio'
@@ -56,6 +57,8 @@ def SortStatsIntoTimeSeries(report_batches):
for stat_name, value in report.iteritems():
if stat_name not in INTERESTING_METRICS:
continue
+ if GetReportKind(report) == 'unknown':
+ continue
full_stat_name = DistinguishAudioAndVideo(report, stat_name)
time_series.setdefault(full_stat_name, []).append(float(value))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698