Relax an overly sensentive check in webrtc_stats.py.

Relax an overly sensentive check in webrtc_stats.py.

Exception was thrown and caused test failures when reusing a metric "packetsSent" in connection report. This one is also in the INTERESTING_METRICS and was only existing on audio/video report.

https://webrtc-codereview.appspot.com/25959004/ is the webrtc change which introduces this metrics on connection report to track packet drop due to network issue. This change was reverted due to this test failure.

BUG=

Committed: https://crrev.com/66d50768b202af669bb94a7ae370a45b5b8c6507
Cr-Commit-Position: refs/heads/master@{#304452}

[guoweis2, 2014-11-14 21:46:02]

guoweis@google.com changed reviewers:
+ phoglund@chromium.org

[phoglund_chromium, 2014-11-17 12:29:33]

Right, we shouldn't blow up if bwestats happen to report an "interesting
metric". lgtm, some nits.

https://codereview.chromium.org/729643003/diff/1/tools/perf/metrics/webrtc_st...
File tools/perf/metrics/webrtc_stats.py (right):

https://codereview.chromium.org/729643003/diff/1/tools/perf/metrics/webrtc_st...
tools/perf/metrics/webrtc_stats.py:33: # 'unknown' could return when BWE or
Connection report reuse existing metric
Move this comment to above the return 'unknown' statement.

Also try to phrase it better and end the comment with .

What about:
# There are other kinds of reports, such as bwestats, which we don't care about
here.
# For these cases just return 'unknown' which will ignore the report.

https://codereview.chromium.org/729643003/diff/1/tools/perf/metrics/webrtc_st...
tools/perf/metrics/webrtc_stats.py:41: logging.error('Did not recognize report
batch: %s.', report.keys())
Make this a debug-level statement since this will actually happen without being
an error.

[tonyg, 2014-11-17 16:39:38]

tonyg@chromium.org changed reviewers:
+ tonyg@chromium.org

[tonyg, 2014-11-17 16:39:38]

lgtm owners stamp for after phoglund's comments are addressed.

[guoweis2, 2014-11-17 17:34:53]

The CQ bit was checked by guoweis@google.com

[commit-bot: I haz the power, 2014-11-17 17:35:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/729643003/40001

[chromium-reviews, 2014-11-17 17:36:15]

all comments are addressed. Thanks.

Thanks,
Guowei

On Mon, Nov 17, 2014 at 9:35 AM, <commit-bot@chromium.org> wrote:

> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/729643003/40001
>
>
> https://codereview.chromium.org/729643003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-11-17 19:37:39]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-11-17 19:38:30]

Patchset 3 (id:??) landed as
https://crrev.com/66d50768b202af669bb94a7ae370a45b5b8c6507
Cr-Commit-Position: refs/heads/master@{#304452}