Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 729583002: Added missing validation (Closed)

Created:
6 years, 1 month ago by sugoi1
Modified:
6 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/effects/SkMatrixConvolutionImageFilter.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
sugoi1
6 years, 1 month ago (2014-11-14 18:32:21 UTC) #2
reed1
I don't know how kernelOffset is used.
6 years, 1 month ago (2014-11-14 18:55:18 UTC) #4
sugoi1
On 2014/11/14 18:55:18, reed1 wrote: > I don't know how kernelOffset is used. It's used ...
6 years, 1 month ago (2014-11-14 19:02:41 UTC) #5
bsalomon
I think Stephen would be the right person to review this.
6 years, 1 month ago (2014-11-14 19:34:08 UTC) #7
Stephen White
LGTM
6 years, 1 month ago (2014-11-14 21:27:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/729583002/1
6 years, 1 month ago (2014-11-17 13:37:41 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-17 13:45:59 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1379b87ae463246e586b869f7457ce5befc4472c

Powered by Google App Engine
This is Rietveld 408576698