Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Unified Diff: sky/tools/webkitpy/layout_tests/controllers/single_test_runner.py

Issue 729573004: Only write test baselines next to the test. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/tools/webkitpy/layout_tests/controllers/single_test_runner.py
diff --git a/sky/tools/webkitpy/layout_tests/controllers/single_test_runner.py b/sky/tools/webkitpy/layout_tests/controllers/single_test_runner.py
index db00f607a91d19f469a0d55215ecc6113579d913..a8ca9739aedadc3597a2efd187c3906c4897abeb 100644
--- a/sky/tools/webkitpy/layout_tests/controllers/single_test_runner.py
+++ b/sky/tools/webkitpy/layout_tests/controllers/single_test_runner.py
@@ -168,14 +168,17 @@ class SingleTestRunner(object):
self._save_baseline_data(driver_output.image, '.png', self._location_for_new_baseline(driver_output.image, '.png'))
def _location_for_new_baseline(self, data, extension):
- if self._options.add_platform_exceptions:
- return self.VERSION_DIR
- if extension == '.png':
- return self.PLATFORM_DIR
- if extension == '.wav':
- return self.ALONGSIDE_TEST
- if extension == '.txt' and self._render_tree_dump_pattern.match(data):
- return self.PLATFORM_DIR
+ # TODO(ojan): Remove all of this baseline location stuff now that we
+ # only have one baseline directory.
+
+ # if self._options.add_platform_exceptions:
+ # return self.VERSION_DIR
+ # if extension == '.png':
+ # return self.PLATFORM_DIR
+ # if extension == '.wav':
+ # return self.ALONGSIDE_TEST
+ # if extension == '.txt' and self._render_tree_dump_pattern.match(data):
+ # return self.PLATFORM_DIR
return self.ALONGSIDE_TEST
def _overwrite_baselines(self, driver_output):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698