Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 729573003: Pass script-based locale names to Skia (Closed)

Created:
6 years, 1 month ago by Xianzhu
Modified:
6 years, 1 month ago
CC:
blink-reviews, krit, Rik, jbroman, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Pass script-based locale names to Skia Skia on Android (required by /system/etc/fallback_fonts.xml) on L requires script-based locale names (e.g. zh-Hans and zh-Hant), but chromium uses region-based locale names (e.g. zh-CN and zh-TW). Convert region-based locale names to scirpt-based locale names before passing locale names to Skia. For now this is for "zh" only. BUG=433074 TEST=ManualTests/zh-font-fallback-android.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185464

Patch Set 1 #

Patch Set 2 : Add a manual test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -2 lines) Patch
A ManualTests/resources/zh-hans.png View 1 Binary file 0 comments Download
A ManualTests/resources/zh-hant.png View 1 Binary file 0 comments Download
A ManualTests/zh-font-fallback-android.html View 1 1 chunk +16 lines, -0 lines 0 comments Download
M Source/platform/fonts/android/FontCacheAndroid.cpp View 1 chunk +20 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Xianzhu
6 years, 1 month ago (2014-11-14 19:35:59 UTC) #2
eae
On 2014/11/14 19:35:59, Xianzhu wrote: Could you add a test for this please?
6 years, 1 month ago (2014-11-14 19:42:39 UTC) #3
Xianzhu
On 2014/11/14 19:42:39, eae wrote: > On 2014/11/14 19:35:59, Xianzhu wrote: > > Could you ...
6 years, 1 month ago (2014-11-14 20:04:24 UTC) #4
Xianzhu
On 2014/11/14 20:04:24, Xianzhu wrote: > On 2014/11/14 19:42:39, eae wrote: > > On 2014/11/14 ...
6 years, 1 month ago (2014-11-17 17:54:29 UTC) #5
eae
LGTM
6 years, 1 month ago (2014-11-17 19:17:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/729573003/20001
6 years, 1 month ago (2014-11-17 19:21:09 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-17 20:26:56 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 185464

Powered by Google App Engine
This is Rietveld 408576698