Issue 729573002: Revert of HTMLPlugInElement: Use custom focus logic only when there is a plugin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 729573002: Revert of HTMLPlugInElement: Use custom focus logic only when there is a plugin. (Closed)

Created:
6 years, 1 month ago by jbroman

Modified:
6 years, 1 month ago

Reviewers:
esprehn, Mike West

CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Revert of HTMLPlugInElement: Use custom focus logic only when there is a plugin. (patchset #1 id:1 of https://codereview.chromium.org/717193003/) Reason for revert: probable cause of use-after-free: https://code.google.com/p/chromium/issues/detail?id=433357 Original issue's description: > HTMLPlugInElement: Use custom focus logic only when there is a plugin. > > This allows focus to enter and leave plugin placeholders, so that constituent > elements (such as a close button) can be keyboard-focused. > > TEST=fast/plugins/plugin/placeholder-focus.html > BUG=364716 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185290 TBR=mkwst@chromium.org,esprehn@chromium.org NOTREECHECKS=true NOTRY=true BUG=364716 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185383

Created: 6 years, 1 month ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+1 line, -46 lines)			Patch
D	LayoutTests/fast/plugins/plugin-placeholder-focus.html	View	1 chunk	+0 lines, -27 lines	0 comments	Download
D	LayoutTests/fast/plugins/plugin-placeholder-focus-expected.txt	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	Source/core/html/HTMLPlugInElement.cpp	View	1 chunk	+1 line, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

jbroman

Created Revert of HTMLPlugInElement: Use custom focus logic only when there is a plugin.

6 years, 1 month ago (2014-11-14 18:17:45 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/729573002/1

6 years, 1 month ago (2014-11-14 18:18:23 UTC) #2

commit-bot: I haz the power

6 years, 1 month ago (2014-11-14 18:18:59 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 185383