content/browser/renderer_host/input/input_router_impl_unittest.cc - Issue 729533003: Remove GestureScrollUpdateWithoutPropagation event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/input_router_impl_unittest.cc

Issue 729533003: Remove GestureScrollUpdateWithoutPropagation event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase and fix minor issue in input_router_impl_unittest.cc Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/input/input_router_impl_unittest.cc

diff --git a/content/browser/renderer_host/input/input_router_impl_unittest.cc b/content/browser/renderer_host/input/input_router_impl_unittest.cc

index ed922c9d8ac272bdfd881c47d2b7d8b56add403c..e96f080949d26a24effff4fa336cbbd1c8ee73f6 100644

--- a/content/browser/renderer_host/input/input_router_impl_unittest.cc

+++ b/content/browser/renderer_host/input/input_router_impl_unittest.cc

@@ -992,7 +992,7 @@ TEST_F(InputRouterImplTest, TouchTypesIgnoringAck) {

TEST_F(InputRouterImplTest, GestureTypesIgnoringAck) {

// We test every gesture type, ensuring that the stream of gestures is valid.

- const int kEventTypesLength = 29;

+ const int kEventTypesLength = 28;

WebInputEvent::Type eventTypes[kEventTypesLength] = {

jdduke (slow) 2014/11/26 19:26:03 Could we ditch the hard count and just use |eventT

majidvp 2014/11/27 15:47:55 Done.

WebInputEvent::GestureTapDown,

WebInputEvent::GestureShowPress,

@@ -1018,7 +1018,6 @@ TEST_F(InputRouterImplTest, GestureTypesIgnoringAck) {

WebInputEvent::GestureTapCancel,

WebInputEvent::GestureScrollBegin,

WebInputEvent::GestureScrollUpdate,

- WebInputEvent::GestureScrollUpdateWithoutPropagation,

WebInputEvent::GesturePinchBegin,

WebInputEvent::GesturePinchUpdate,

WebInputEvent::GesturePinchEnd,