Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 729523005: [Ozone] Fix SoftwareOutputDevice tests (Closed)

Created:
6 years, 1 month ago by dnicoara
Modified:
6 years, 1 month ago
Reviewers:
danakj, sadrul
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Ozone] Fix SoftwareOutputDevice tests Content is instantiating the Ozone platform for unittests. Updating unittests to use the OzonePlatform since creating multiple instances of SurfaceFactoryOzone is an error. In order to create a surface it needs a window associated with it. On Ozone, we need to create a PlatformWindow, then we can use the gfx::AcceleratedWidget associated with it to create a surface. BUG=none NOTRY=true Committed: https://crrev.com/c0a3717f3da829d0704ad46c8e3af45ea617660c Cr-Commit-Position: refs/heads/master@{#304854}

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Total comments: 4

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -46 lines) Patch
A content/browser/compositor/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/compositor/software_output_device_ozone_unittest.cc View 1 2 4 chunks +30 lines, -46 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
dnicoara
PTAL danakj@ for everything sadrul@ for ui/platform_window DEPS
6 years, 1 month ago (2014-11-19 16:18:04 UTC) #2
sadrul
lgtm https://codereview.chromium.org/729523005/diff/1/content/browser/compositor/software_output_device_ozone_unittest.cc File content/browser/compositor/software_output_device_ozone_unittest.cc (right): https://codereview.chromium.org/729523005/diff/1/content/browser/compositor/software_output_device_ozone_unittest.cc#newcode27 content/browser/compositor/software_output_device_ozone_unittest.cc:27: TestPlatformWindowDelegate() {} Initialize widget_?
6 years, 1 month ago (2014-11-19 17:26:01 UTC) #3
dnicoara
Thanks! https://codereview.chromium.org/729523005/diff/1/content/browser/compositor/software_output_device_ozone_unittest.cc File content/browser/compositor/software_output_device_ozone_unittest.cc (right): https://codereview.chromium.org/729523005/diff/1/content/browser/compositor/software_output_device_ozone_unittest.cc#newcode27 content/browser/compositor/software_output_device_ozone_unittest.cc:27: TestPlatformWindowDelegate() {} On 2014/11/19 17:26:00, sadrul wrote: > ...
6 years, 1 month ago (2014-11-19 17:38:16 UTC) #4
danakj
https://codereview.chromium.org/729523005/diff/20001/content/browser/compositor/software_output_device_ozone_unittest.cc File content/browser/compositor/software_output_device_ozone_unittest.cc (right): https://codereview.chromium.org/729523005/diff/20001/content/browser/compositor/software_output_device_ozone_unittest.cc#newcode68 content/browser/compositor/software_output_device_ozone_unittest.cc:68: scoped_ptr<TestPlatformWindowDelegate> window_delegate_; any reason why it's in a scoped_ptr ...
6 years, 1 month ago (2014-11-19 18:53:16 UTC) #5
dnicoara
https://codereview.chromium.org/729523005/diff/20001/content/browser/compositor/software_output_device_ozone_unittest.cc File content/browser/compositor/software_output_device_ozone_unittest.cc (right): https://codereview.chromium.org/729523005/diff/20001/content/browser/compositor/software_output_device_ozone_unittest.cc#newcode68 content/browser/compositor/software_output_device_ozone_unittest.cc:68: scoped_ptr<TestPlatformWindowDelegate> window_delegate_; On 2014/11/19 18:53:16, danakj wrote: > any ...
6 years, 1 month ago (2014-11-19 18:58:51 UTC) #6
danakj
LGTM
6 years, 1 month ago (2014-11-19 18:59:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/729523005/40001
6 years, 1 month ago (2014-11-19 19:01:40 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-19 19:02:51 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 19:03:27 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c0a3717f3da829d0704ad46c8e3af45ea617660c
Cr-Commit-Position: refs/heads/master@{#304854}

Powered by Google App Engine
This is Rietveld 408576698