Add fast/inline to virtual/slimmingpaint and make the tests pass

Add fast/inline to virtual/slimmingpaint and make the tests pass

Minor collateral damage (for-range loop, removed redundant parens).

BUG=423071
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185516

[fs, 2014-11-14 16:42:59]

fs@opera.com changed reviewers:
+ chrishtr@chromium.org, leviw@chromium.org, slimming-paint-reviews@chromium.org

[leviw_travelin_and_unemployed, 2014-11-14 22:28:00]

https://codereview.chromium.org/729523002/diff/1/LayoutTests/virtual/slimming...
File LayoutTests/virtual/slimmingpaint/fast/inline/README.txt (right):

https://codereview.chromium.org/729523002/diff/1/LayoutTests/virtual/slimming...
LayoutTests/virtual/slimmingpaint/fast/inline/README.txt:1: # This suite runs
the tests in fast/inline with --enable-slimming-paint
Technically now it's fast/block AND fast/inline ;)

https://codereview.chromium.org/729523002/diff/1/Source/core/paint/InlinePain...
File Source/core/paint/InlinePainter.cpp (right):

https://codereview.chromium.org/729523002/diff/1/Source/core/paint/InlinePain...
Source/core/paint/InlinePainter.cpp:35: bounds =
m_renderInline.linesVisualOverflowBoundingBox();
This is going to be really expensive to calculate for every inline. We don't
need this to wrap perfectly. We should just use the cached visual overflow from
our containing block.

[leviw_travelin_and_unemployed, 2014-11-14 22:28:48]

It also looks like we're failing on Mac.

[chrishtr, 2014-11-14 22:31:44]

https://codereview.chromium.org/729523002/diff/1/Source/core/paint/InlinePain...
File Source/core/paint/InlinePainter.cpp (right):

https://codereview.chromium.org/729523002/diff/1/Source/core/paint/InlinePain...
Source/core/paint/InlinePainter.cpp:35: bounds =
m_renderInline.linesVisualOverflowBoundingBox();
On 2014/11/14 at 22:27:59, leviw wrote:
> This is going to be really expensive to calculate for every inline. We don't
need this to wrap perfectly. We should just use the cached visual overflow from
our containing block.

It suffices to use a bound that includes the inline, so use the bounds of the
entire line box list?

[fs, 2014-11-17 16:13:20]

On 2014/11/14 22:28:48, leviw wrote:
> It also looks like we're failing on Mac.

virtual/slimmingpaint/fast/inline/justify-emphasis-inline-box.html

 - The original test had a NeedsManualRebaseline in TestExpectations, so I added
a corresponding one for the virtual/slimmingpaint test. (The result did not look
obviously wrong to me - how do you justify a single glyph anyway? =))

virtual/slimmingpaint/fast/inline/positionedLifetime.html

 - Trouble w/ themed radio button. See change in BoxPainter.

https://codereview.chromium.org/729523002/diff/1/LayoutTests/virtual/slimming...
File LayoutTests/virtual/slimmingpaint/fast/inline/README.txt (right):

https://codereview.chromium.org/729523002/diff/1/LayoutTests/virtual/slimming...
LayoutTests/virtual/slimmingpaint/fast/inline/README.txt:1: # This suite runs
the tests in fast/inline with --enable-slimming-paint
On 2014/11/14 22:27:59, leviw wrote:
> Technically now it's fast/block AND fast/inline ;)

I suppose it's a question of whether we want to keep updating all the
subdirectories or not. I opted for "not".

https://codereview.chromium.org/729523002/diff/1/Source/core/paint/InlinePain...
File Source/core/paint/InlinePainter.cpp (right):

https://codereview.chromium.org/729523002/diff/1/Source/core/paint/InlinePain...
Source/core/paint/InlinePainter.cpp:35: bounds =
m_renderInline.linesVisualOverflowBoundingBox();
On 2014/11/14 22:31:43, chrishtr wrote:
> On 2014/11/14 at 22:27:59, leviw wrote:
> > This is going to be really expensive to calculate for every inline. We don't
> need this to wrap perfectly. We should just use the cached visual overflow
from
> our containing block.
> 
> It suffices to use a bound that includes the inline, so use the bounds of the
> entire line box list?

I've used Levi's suggestion for now. I'm not sure how the bounds of the entire
line box list (assuming that means root box list?) would be cheaper - could you
elaborate?

[leviw_travelin_and_unemployed, 2014-11-17 19:57:25]

LGTM.

We could walk just the root boxes, but if something like that is necessary we
can probably come up with a better, if more involved solution. I think this is
fine for now.

https://codereview.chromium.org/729523002/diff/1/LayoutTests/virtual/slimming...
File LayoutTests/virtual/slimmingpaint/fast/inline/README.txt (right):

https://codereview.chromium.org/729523002/diff/1/LayoutTests/virtual/slimming...
LayoutTests/virtual/slimmingpaint/fast/inline/README.txt:1: # This suite runs
the tests in fast/inline with --enable-slimming-paint
On 2014/11/17 16:13:20, fs wrote:
> On 2014/11/14 22:27:59, leviw wrote:
> > Technically now it's fast/block AND fast/inline ;)
> 
> I suppose it's a question of whether we want to keep updating all the
> subdirectories or not. I opted for "not".

Totally :)

[fs, 2014-11-18 11:31:00]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2014-11-18 11:31:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/729523002/60001

[commit-bot: I haz the power, 2014-11-18 12:21:05]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185516