DevTools: Gracefully ignore unknown variable scopes.

DevTools: Gracefully ignore unknown variable scopes.

BUG=433324
R=yurys, dslomov

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185426

[yurys, 2014-11-14 16:08:55]

https://codereview.chromium.org/729513002/diff/1/Source/bindings/core/v8/Debu...
File Source/bindings/core/v8/DebuggerScript.js (right):

https://codereview.chromium.org/729513002/diff/1/Source/bindings/core/v8/Debu...
Source/bindings/core/v8/DebuggerScript.js:80: var scopeObject =
DebuggerScript._buildScopeObject(scopeDetails.type(), scopeDetails.object());
Why not support the new scope type instead? New scope types are not added often
and we anyways need to support all of them.

[Dmitry Lomov (no reviews), 2014-11-14 16:11:00]

dslomov@chromium.org changed reviewers:
+ dslomov@chromium.org
- dslomov@gmail.com

[aandrey, 2014-11-14 16:12:38]

On 2014/11/14 16:08:55, yurys wrote:
>
https://codereview.chromium.org/729513002/diff/1/Source/bindings/core/v8/Debu...
> File Source/bindings/core/v8/DebuggerScript.js (right):
> 
>
https://codereview.chromium.org/729513002/diff/1/Source/bindings/core/v8/Debu...
> Source/bindings/core/v8/DebuggerScript.js:80: var scopeObject =
> DebuggerScript._buildScopeObject(scopeDetails.type(), scopeDetails.object());
> Why not support the new scope type instead? New scope types are not added
often
> and we anyways need to support all of them.

We will support.
The point of this patch is to prevent crashes if V8 feeds us with a new scope
type.

Anyway this should have been done so already, so that V8 should be free to add
new features w/o breaking DevTools.

[aandrey, 2014-11-14 16:22:42]

Moreover, we have to wait for V8 to support the new scope type so that we should
not break our layout tests.

[Dmitry Lomov (no reviews), 2014-11-14 16:24:20]

On 2014/11/14 16:22:42, aandrey wrote:
> Moreover, we have to wait for V8 to support the new scope type so that we
should
> not break our layout tests.

+1 - support for new scope types might take some time, the less lock-step
development we need the better

[yurys, 2014-11-14 16:47:26]

lgtm

[aandrey, 2014-11-14 19:56:29]

The CQ bit was checked by aandrey@chromium.org

[aandrey, 2014-11-14 19:57:00]

The CQ bit was unchecked by aandrey@chromium.org

[aandrey, 2014-11-17 08:35:22]

The CQ bit was checked by aandrey@chromium.org

[commit-bot: I haz the power, 2014-11-17 08:36:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/729513002/40001

[commit-bot: I haz the power, 2014-11-17 09:38:51]

Committed patchset #3 (id:40001) as 185426