LayoutTests/inspector/elements/set-outer-html-for-xhtml.xhtml - Issue 729453003: DevTools: Fix crash when setting invalid outer XML for an XML document

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/inspector/elements/set-outer-html-for-xhtml.xhtml

Issue 729453003: DevTools: Fix crash when setting invalid outer XML for an XML document (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Revert to ASSERT, detach parser() after finish() Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: LayoutTests/inspector/elements/set-outer-html-for-xhtml.xhtml

diff --git a/LayoutTests/inspector/elements/set-outer-html-for-xhtml.xhtml b/LayoutTests/inspector/elements/set-outer-html-for-xhtml.xhtml

index c020ac25d195e453c6e459b9c500bf032f4556fa..cce14b19efdb17b69f54e650339081a2abc5c43e 100644

--- a/LayoutTests/inspector/elements/set-outer-html-for-xhtml.xhtml

+++ b/LayoutTests/inspector/elements/set-outer-html-for-xhtml.xhtml

@@ -1,4 +1,4 @@

-<html xmlns="http://www.w3.org/1999/xhtml">

+<html id="html" xmlns="http://www.w3.org/1999/xhtml">

<head>

@@ -44,6 +44,18 @@ function test()

function testChangeNodeName(next)

{

InspectorTest.patchOuterHTML("<h2>Getting involved</h2>", "<h3>Getting involved</h3>", next);

+ },

+ function testInvalidDocumentDoesNotCrash(next)

+ {

+ var htmlId = InspectorTest.expandedNodeWithId("html").id;

+ DOMAgent.setOuterHTML(htmlId, "foo", callback);

+ function callback()

+ {

+ InspectorTest.addResult("PASS: No crash");

+ next();

+ }

}

]);

}