Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: LayoutTests/inspector/elements/set-outer-html-for-xhtml.xhtml

Issue 729453003: DevTools: Fix crash when setting invalid outer XML for an XML document (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/inspector/elements/set-outer-html-for-xhtml-expected.txt » ('j') | Source/core/inspector/DOMPatchSupport.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/inspector/elements/set-outer-html-for-xhtml.xhtml
diff --git a/LayoutTests/inspector/elements/set-outer-html-for-xhtml.xhtml b/LayoutTests/inspector/elements/set-outer-html-for-xhtml.xhtml
index c020ac25d195e453c6e459b9c500bf032f4556fa..45c0289e1052ff83d34ef52c724fc40a237a7e79 100644
--- a/LayoutTests/inspector/elements/set-outer-html-for-xhtml.xhtml
+++ b/LayoutTests/inspector/elements/set-outer-html-for-xhtml.xhtml
@@ -1,4 +1,4 @@
-<html xmlns="http://www.w3.org/1999/xhtml">
+<html id="html" xmlns="http://www.w3.org/1999/xhtml">
<head>
<script src="../../http/tests/inspector/inspector-test.js"></script>
@@ -44,6 +44,18 @@ function test()
function testChangeNodeName(next)
{
InspectorTest.patchOuterHTML("<h2>Getting involved</h2>", "<h3>Getting involved</h3>", next);
+ },
+
+ function testInvalidDocumentDoesNotCrash(next)
+ {
+ var htmlId = InspectorTest.expandedNodeWithId("html").id;
+ DOMAgent.setOuterHTML(htmlId, "foo", callback);
+
+ function callback()
+ {
+ InspectorTest.addResult("No crash");
aandrey 2014/11/14 16:30:53 nit: "PASS: No crash"
apavlov 2014/11/17 13:37:18 Done.
+ next();
+ }
}
]);
}
« no previous file with comments | « no previous file | LayoutTests/inspector/elements/set-outer-html-for-xhtml-expected.txt » ('j') | Source/core/inspector/DOMPatchSupport.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698