Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 729413003: Remove GraphicsContext::didDrawRect. (Closed)

Created:
6 years, 1 month ago by jbroman
Modified:
6 years, 1 month ago
CC:
blink-reviews, krit, Rik, jbroman, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Project:
blink
Visibility:
Public.

Description

Remove GraphicsContext::didDrawRect. The only call site (NativeImageSkia::draw) already does the same work via GraphicsContext::drawBitmapRect. BUG=433902 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185466

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M Source/platform/graphics/GraphicsContext.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/platform/graphics/GraphicsContext.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/platform/graphics/skia/NativeImageSkia.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
jbroman
trivial
6 years, 1 month ago (2014-11-17 18:36:20 UTC) #2
f(malita)
lgtm
6 years, 1 month ago (2014-11-17 19:29:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/729413003/1
6 years, 1 month ago (2014-11-17 19:30:37 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-17 21:18:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185466

Powered by Google App Engine
This is Rietveld 408576698