Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 729343003: Handle AX help-Text for media time slider. (Closed)

Created:
6 years, 1 month ago by je_julie(Not used)
Modified:
6 years, 1 month ago
Reviewers:
dmazzoni, Mike West
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Handle AX help-Text for media time slider. The AX help-text for media time slider is used for audio and video with "movie time scrubber". But it's not proper to audio time slider. This patch adds help-text for audio time slider, makes help-text check if it is audio or video and applies proper help-text. BUG=431233 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185539

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -13 lines) Patch
M Source/modules/accessibility/AXMediaControls.cpp View 3 chunks +3 lines, -13 lines 0 comments Download
M Source/modules/accessibility/AXNodeObject.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/accessibility/AXNodeObject.cpp View 2 chunks +11 lines, -0 lines 0 comments Download
M public/platform/WebLocalizedString.h View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
je_julie(Not used)
Dominic and Mike, This patch handles help-text for audio time slider on Blink and also ...
6 years, 1 month ago (2014-11-18 00:03:59 UTC) #2
Mike West
LGTM.
6 years, 1 month ago (2014-11-18 07:54:05 UTC) #3
dmazzoni
lgtm
6 years, 1 month ago (2014-11-18 16:57:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/729343003/1
6 years, 1 month ago (2014-11-18 16:58:05 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-18 18:19:20 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185539

Powered by Google App Engine
This is Rietveld 408576698