Add PostMessage support for MimeHandlerView

Add PostMessage support for MimeHandlerView

This adds PostMessage support for MimeHandlerView allow sites that embed extension mime handlers to communicate with them.

BUG=415858
Committed: https://crrev.com/19c1d109fa46723cc3844acfaf2631fa7ed11d19
Cr-Commit-Position: refs/heads/master@{#309512}

[raymes, 2014-12-18 03:38:56]

raymes@chromium.org changed reviewers:
+ sammc@chromium.org

[Sam McNally, 2014-12-18 05:36:47]

https://codereview.chromium.org/729333002/diff/40001/content/public/renderer/...
File content/public/renderer/browser_plugin_delegate.cc (right):

https://codereview.chromium.org/729333002/diff/40001/content/public/renderer/...
content/public/renderer/browser_plugin_delegate.cc:9: v8::Local<v8::Object>
BrowserPluginDelegate::v8ScriptableObject(v8::Isolate*) {
Parameter name?

https://codereview.chromium.org/729333002/diff/40001/content/public/renderer/...
File content/public/renderer/browser_plugin_delegate.h (right):

https://codereview.chromium.org/729333002/diff/40001/content/public/renderer/...
content/public/renderer/browser_plugin_delegate.h:39: virtual
v8::Local<v8::Object> v8ScriptableObject(v8::Isolate*);
V8ScriptableObject
Parameter name?

https://codereview.chromium.org/729333002/diff/40001/content/renderer/browser...
File content/renderer/browser_plugin/browser_plugin.h (right):

https://codereview.chromium.org/729333002/diff/40001/content/renderer/browser...
content/renderer/browser_plugin/browser_plugin.h:86: virtual
v8::Local<v8::Object> v8ScriptableObject(v8::Isolate*) override;
Parameter name?

https://codereview.chromium.org/729333002/diff/60001/extensions/renderer/gues...
File
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc
(right):

https://codereview.chromium.org/729333002/diff/60001/extensions/renderer/gues...
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc:64:
.AddNamedPropertyInterceptor();
2 more spaces?

https://codereview.chromium.org/729333002/diff/60001/extensions/renderer/gues...
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc:169:
v8::Local<v8::Object> guest_proxy_window =
I think this would be nicer if it used a gin::Dictionary and gin::ConvertFromV8
to get the function.

https://codereview.chromium.org/729333002/diff/60001/extensions/renderer/gues...
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc:184:
v8::String::NewFromUtf8(isolate, "*", v8::String::kNormalString, 1)
gin::StringToV8?

https://codereview.chromium.org/729333002/diff/60001/extensions/renderer/gues...
File
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h
(right):

https://codereview.chromium.org/729333002/diff/60001/extensions/renderer/gues...
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h:85:
// Save the RenderView RoutingID of the guest here so it can be used to route
This comment should be where the routing ID is saved.

[raymes, 2014-12-19 00:00:16]

https://codereview.chromium.org/729333002/diff/40001/content/public/renderer/...
File content/public/renderer/browser_plugin_delegate.cc (right):

https://codereview.chromium.org/729333002/diff/40001/content/public/renderer/...
content/public/renderer/browser_plugin_delegate.cc:9: v8::Local<v8::Object>
BrowserPluginDelegate::v8ScriptableObject(v8::Isolate*) {
On 2014/12/18 05:36:46, Sam McNally wrote:
> Parameter name?

Done.

https://codereview.chromium.org/729333002/diff/40001/content/public/renderer/...
File content/public/renderer/browser_plugin_delegate.h (right):

https://codereview.chromium.org/729333002/diff/40001/content/public/renderer/...
content/public/renderer/browser_plugin_delegate.h:39: virtual
v8::Local<v8::Object> v8ScriptableObject(v8::Isolate*);
On 2014/12/18 05:36:46, Sam McNally wrote:
> V8ScriptableObject
> Parameter name?

Done.

https://codereview.chromium.org/729333002/diff/40001/content/renderer/browser...
File content/renderer/browser_plugin/browser_plugin.h (right):

https://codereview.chromium.org/729333002/diff/40001/content/renderer/browser...
content/renderer/browser_plugin/browser_plugin.h:86: virtual
v8::Local<v8::Object> v8ScriptableObject(v8::Isolate*) override;
On 2014/12/18 05:36:46, Sam McNally wrote:
> Parameter name?

Done.

https://codereview.chromium.org/729333002/diff/60001/extensions/renderer/gues...
File
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc
(right):

https://codereview.chromium.org/729333002/diff/60001/extensions/renderer/gues...
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc:64:
.AddNamedPropertyInterceptor();
On 2014/12/18 05:36:47, Sam McNally wrote:
> 2 more spaces?

Done.

https://codereview.chromium.org/729333002/diff/60001/extensions/renderer/gues...
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc:169:
v8::Local<v8::Object> guest_proxy_window =
On 2014/12/18 05:36:47, Sam McNally wrote:
> I think this would be nicer if it used a gin::Dictionary and
gin::ConvertFromV8
> to get the function.

Done.

https://codereview.chromium.org/729333002/diff/60001/extensions/renderer/gues...
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc:184:
v8::String::NewFromUtf8(isolate, "*", v8::String::kNormalString, 1)
On 2014/12/18 05:36:47, Sam McNally wrote:
> gin::StringToV8?

Done.

https://codereview.chromium.org/729333002/diff/60001/extensions/renderer/gues...
File
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h
(right):

https://codereview.chromium.org/729333002/diff/60001/extensions/renderer/gues...
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h:85:
// Save the RenderView RoutingID of the guest here so it can be used to route
On 2014/12/18 05:36:47, Sam McNally wrote:
> This comment should be where the routing ID is saved.

Done.

https://codereview.chromium.org/729333002/diff/60001/extensions/renderer/gues...
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h:85:
// Save the RenderView RoutingID of the guest here so it can be used to route
On 2014/12/18 05:36:47, Sam McNally wrote:
> This comment should be where the routing ID is saved.

Done.

[Sam McNally, 2014-12-19 00:18:20]

LGTM

https://codereview.chromium.org/729333002/diff/80001/extensions/renderer/gues...
File
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc
(right):

https://codereview.chromium.org/729333002/diff/80001/extensions/renderer/gues...
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc:175:
if (post_message.IsEmpty())
Checking the return value of Get() should be sufficient.

[raymes, 2014-12-19 02:10:23]

raymes@chromium.org changed reviewers:
+ fsamuel@chromium.org

[raymes, 2014-12-19 02:10:24]

+fsamuel for OWNERS

Thanks!

[raymes, 2014-12-19 03:23:23]

(also note that there is a test for this in a separate CL ready for review after
this :)

[Fady Samuel, 2014-12-19 03:23:28]

browser_plugin lgtm

[raymes, 2014-12-19 05:00:47]

raymes@chromium.org changed reviewers:
+ jochen@chromium.org

[raymes, 2014-12-19 05:00:48]

+jochen for content/* OWNERS

[jochen (gone - plz use gerrit), 2014-12-22 14:17:29]

lgtm with comment addressed

https://codereview.chromium.org/729333002/diff/100001/content/public/renderer...
File content/public/renderer/browser_plugin_delegate.h (right):

https://codereview.chromium.org/729333002/diff/100001/content/public/renderer...
content/public/renderer/browser_plugin_delegate.h:44: virtual
v8::Local<v8::Object> V8ScriptableObject(v8::Isolate* isolate);
plz forward declare the v8 stuff

namespace v8 {
class Object;
class Isolate;
template<typename T> class Handle;
}

[raymes, 2014-12-22 23:41:29]

Thanks!

https://codereview.chromium.org/729333002/diff/100001/content/public/renderer...
File content/public/renderer/browser_plugin_delegate.h (right):

https://codereview.chromium.org/729333002/diff/100001/content/public/renderer...
content/public/renderer/browser_plugin_delegate.h:44: virtual
v8::Local<v8::Object> V8ScriptableObject(v8::Isolate* isolate);
On 2014/12/22 14:17:29, jochen (slow) wrote:
> plz forward declare the v8 stuff
> 
> namespace v8 {
> class Object;
> class Isolate;
> template<typename T> class Handle;
> }

Done.

[raymes, 2014-12-22 23:41:34]

The CQ bit was checked by raymes@chromium.org

[commit-bot: I haz the power, 2014-12-22 23:42:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/729333002/120001

[commit-bot: I haz the power, 2014-12-22 23:54:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-22 23:54:38]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[raymes, 2014-12-23 00:04:02]

The CQ bit was checked by raymes@chromium.org

[commit-bot: I haz the power, 2014-12-23 00:05:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/729333002/140001

[commit-bot: I haz the power, 2014-12-23 01:23:44]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2014-12-23 01:24:26]

Patchset 8 (id:??) landed as
https://crrev.com/19c1d109fa46723cc3844acfaf2631fa7ed11d19
Cr-Commit-Position: refs/heads/master@{#309512}