Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: src/trusted/plugin/ppapi/scriptable_handle_ppapi.h

Issue 7292002: Remove plugin connection to PPAPI scriptable objects (var deprecated). Also (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/trusted/plugin/ppapi/plugin_ppapi.cc ('k') | src/trusted/plugin/ppapi/scriptable_handle_ppapi.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/trusted/plugin/ppapi/scriptable_handle_ppapi.h
===================================================================
--- src/trusted/plugin/ppapi/scriptable_handle_ppapi.h (revision 6005)
+++ src/trusted/plugin/ppapi/scriptable_handle_ppapi.h (working copy)
@@ -30,18 +30,6 @@
// If not NULL, this var should be reused to pass this object to the browser.
pp::VarPrivate* var() { return var_; }
-// Turn off the ability to set a proxy if we're removing scripting. In this
-// case, the ScriptableHandle can only refer to the NaCl plugin.
-// TODO(dmichael): Clean up all traces of scripting proxying.
-#ifndef PPAPI_INSTANCE_REMOVE_SCRIPTING
- // If this scriptable handle corresponds to the NaCl plugin itself and the
- // plugin has successfully loaded the NaCl module and started proxied
- // execution, scripting should be redirected via this proxy.
- void set_scriptable_proxy(const pp::VarPrivate& proxy) {
- scriptable_proxy_ = proxy;
- }
-#endif
-
// ------ Methods inherited from pp::deprecated::ScriptableObject:
// Returns true for preloaded NaCl Plugin properties.
@@ -120,19 +108,6 @@
int num_unref_calls_;
bool handle_is_plugin_; // Whether (portable) handle() is a plugin.
-
-#ifdef PPAPI_INSTANCE_REMOVE_SCRIPTING
- // If untrusted scripting is disabled, make this a VarPrivate just so that
- // it has all the methods it needs to compile. This is a hack to avoid having
- // conditional compilation at every call-site for things like HasProperty,
- // HasMethod, etc. We turn off untrusted scripting above by removing the
- // setter for scriptable_proxy_, so it's always invalid.
- // TODO(dmichael): Remove scriptable_proxy_ and all other traces of untrusted
- // scripting.
- pp::VarPrivate scriptable_proxy_;
-#else
- pp::Var scriptable_proxy_; // Proxy for NaCl module's scripting interface.
-#endif
};
} // namespace plugin
« no previous file with comments | « src/trusted/plugin/ppapi/plugin_ppapi.cc ('k') | src/trusted/plugin/ppapi/scriptable_handle_ppapi.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698