Remove plugin connection to PPAPI scriptable objects (var deprecated). Also

Remove plugin connection to PPAPI scriptable objects (var deprecated).  Also
removes the last few tests that relied only on these APIs.
BUG=none
TEST=chrome_browser_tests, trybots
Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=6010

[sehr (please use chromium), 2011-06-30 19:53:41]

When, in the course of human events, it becomes necessary for one executable to
dissolve the proxy bands which have connected it with another...

[dmichael (off chromium), 2011-06-30 21:08:22]

LGTM!!

[dmichael (off chromium), 2011-06-30 22:26:19]

Wait, wait, LGTM retracted :-(

We need to update the ppapi tests first and roll them in; they currently rely on
scripting.  I'm working on that now.  The pyauto_tests step is failing as a
result.

[sehr (please use chromium), 2011-07-11 20:29:48]

On 2011/06/30 22:26:19, dmichael1 wrote:
> Wait, wait, LGTM retracted :-(
> 
> We need to update the ppapi tests first and roll them in; they currently rely
on
> scripting.  I'm working on that now.  The pyauto_tests step is failing as a
> result.

Now that dmichael1 has updated DEPS and removed the questionable tests, I am
again ready to try.  LGTM fervently hoped for.

[dmichael (off chromium), 2011-07-11 20:49:47]

I think you're going to also need to turn off PPAPITest.Messaging. Ironically,
it relies on scripting (my bad). This of course is not a problem in the Chrome
tree.

But we have a proxy test for messaging anyway, so shouldn't hurt our coverage. I
can try to make that test not rely on scripting eventually if we care.

[dmichael (off chromium), 2011-07-11 21:11:33]

LGTM, hooray!

[polina, 2011-07-12 08:58:01]

Hurah!

http://codereview.chromium.org/7292002/diff/13066/tests/ppapi_test_example/pp...
File tests/ppapi_test_example/ppapi_test_example.cc (right):

http://codereview.chromium.org/7292002/diff/13066/tests/ppapi_test_example/pp...
tests/ppapi_test_example/ppapi_test_example.cc:22: void TestSimpleAsync() {
Please drop Async postfixes now.

http://codereview.chromium.org/7292002/diff/13066/tests/ppapi_test_example/pp...
File tests/ppapi_test_example/ppapi_test_example.js (right):

http://codereview.chromium.org/7292002/diff/13066/tests/ppapi_test_example/pp...
tests/ppapi_test_example/ppapi_test_example.js:8: // Below are the before &
after versions of sample test cases demonstrating
forgot this comment

http://codereview.chromium.org/7292002/diff/13066/tests/ppapi_test_example/pp...
tests/ppapi_test_example/ppapi_test_example.js:12: // After.
forgot this one

http://codereview.chromium.org/7292002/diff/13066/tests/ppapi_test_example/pp...
tests/ppapi_test_example/ppapi_test_example.js:13:
tester.addAsyncTest('Example::SimpleAsync', function(status) {
Please drop Async in this file as well.

http://codereview.chromium.org/7292002/diff/13066/tests/ppapi_test_example/pp...
tests/ppapi_test_example/ppapi_test_example.js:25: // After.
and this one

http://codereview.chromium.org/7292002/diff/13066/tests/ppapi_test_example/pp...
tests/ppapi_test_example/ppapi_test_example.js:39: // </IGNORE>
this IGNORE section should now go away

http://codereview.chromium.org/7292002/diff/13066/tests/ppapi_test_lib/test_i...
File tests/ppapi_test_lib/test_interface.h (right):

http://codereview.chromium.org/7292002/diff/13066/tests/ppapi_test_lib/test_i...
tests/ppapi_test_lib/test_interface.h:15: //   PP_Var TestPPBFooDeprecated() {
please remove

http://codereview.chromium.org/7292002/diff/13066/tests/ppapi_test_lib/test_i...
tests/ppapi_test_lib/test_interface.h:32: //     EXPECT_ASYNC(my_resource ==
kInvalidResource);
If it's not too much trouble, could you also please rename these back to EXPECT
and TEST_PASSED?

I have a CL for this, but it might cleaner to do this here instead.

http://codereview.chromium.org/7292002/diff/13066/tests/ppapi_test_lib/test_i...
tests/ppapi_test_lib/test_interface.h:100: // Use these macros to verify the
result of a test and report failures.
s/these macros//

http://codereview.chromium.org/7292002/diff/13066/tests/ppapi_test_lib/test_i...
tests/ppapi_test_lib/test_interface.h:112: #define EXPECT(expr) do { \
this can go away

http://codereview.chromium.org/7292002/diff/13066/tests/ppapi_test_lib/test_i...
tests/ppapi_test_lib/test_interface.h:122: // Use these macros to report
success.
s/these macros//

http://codereview.chromium.org/7292002/diff/13066/tests/ppapi_test_lib/test_i...
tests/ppapi_test_lib/test_interface.h:124: #define TEST_PASSED
PP_MakeBool(PP_TRUE)  // Usage: return TEST_PASSED;
this can go away

[sehr (please use chromium), 2011-07-12 16:44:23]

New version uploaded.  Hopefully final trybot run in progress.

http://codereview.chromium.org/7292002/diff/13066/tests/ppapi_test_example/pp...
File tests/ppapi_test_example/ppapi_test_example.cc (right):

http://codereview.chromium.org/7292002/diff/13066/tests/ppapi_test_example/pp...
tests/ppapi_test_example/ppapi_test_example.cc:22: void TestSimpleAsync() {
On 2011/07/12 08:58:01, polina wrote:
> Please drop Async postfixes now.

Done.

http://codereview.chromium.org/7292002/diff/13066/tests/ppapi_test_example/pp...
File tests/ppapi_test_example/ppapi_test_example.js (right):

http://codereview.chromium.org/7292002/diff/13066/tests/ppapi_test_example/pp...
tests/ppapi_test_example/ppapi_test_example.js:8: // Below are the before &
after versions of sample test cases demonstrating
On 2011/07/12 08:58:01, polina wrote:
> forgot this comment

Done.

http://codereview.chromium.org/7292002/diff/13066/tests/ppapi_test_example/pp...
tests/ppapi_test_example/ppapi_test_example.js:12: // After.
On 2011/07/12 08:58:01, polina wrote:
> forgot this one

Done.

http://codereview.chromium.org/7292002/diff/13066/tests/ppapi_test_example/pp...
tests/ppapi_test_example/ppapi_test_example.js:13:
tester.addAsyncTest('Example::SimpleAsync', function(status) {
On 2011/07/12 08:58:01, polina wrote:
> Please drop Async in this file as well.

Done.

http://codereview.chromium.org/7292002/diff/13066/tests/ppapi_test_example/pp...
tests/ppapi_test_example/ppapi_test_example.js:25: // After.
On 2011/07/12 08:58:01, polina wrote:
> and this one

Done.

http://codereview.chromium.org/7292002/diff/13066/tests/ppapi_test_example/pp...
tests/ppapi_test_example/ppapi_test_example.js:39: // </IGNORE>
On 2011/07/12 08:58:01, polina wrote:
> this IGNORE section should now go away

Done.

http://codereview.chromium.org/7292002/diff/13066/tests/ppapi_test_lib/test_i...
File tests/ppapi_test_lib/test_interface.h (right):

http://codereview.chromium.org/7292002/diff/13066/tests/ppapi_test_lib/test_i...
tests/ppapi_test_lib/test_interface.h:15: //   PP_Var TestPPBFooDeprecated() {
On 2011/07/12 08:58:01, polina wrote:
> please remove

Done.

http://codereview.chromium.org/7292002/diff/13066/tests/ppapi_test_lib/test_i...
tests/ppapi_test_lib/test_interface.h:32: //     EXPECT_ASYNC(my_resource ==
kInvalidResource);
On 2011/07/12 08:58:01, polina wrote:
> If it's not too much trouble, could you also please rename these back to
EXPECT
> and TEST_PASSED?
> 
> I have a CL for this, but it might cleaner to do this here instead.

Done.

http://codereview.chromium.org/7292002/diff/13066/tests/ppapi_test_lib/test_i...
tests/ppapi_test_lib/test_interface.h:100: // Use these macros to verify the
result of a test and report failures.
On 2011/07/12 08:58:01, polina wrote:
> s/these macros//

Done.

http://codereview.chromium.org/7292002/diff/13066/tests/ppapi_test_lib/test_i...
tests/ppapi_test_lib/test_interface.h:112: #define EXPECT(expr) do { \
On 2011/07/12 08:58:01, polina wrote:
> this can go away

Done.

http://codereview.chromium.org/7292002/diff/13066/tests/ppapi_test_lib/test_i...
tests/ppapi_test_lib/test_interface.h:122: // Use these macros to report
success.
On 2011/07/12 08:58:01, polina wrote:
> s/these macros//

Done.

http://codereview.chromium.org/7292002/diff/13066/tests/ppapi_test_lib/test_i...
tests/ppapi_test_lib/test_interface.h:124: #define TEST_PASSED
PP_MakeBool(PP_TRUE)  // Usage: return TEST_PASSED;
On 2011/07/12 08:58:01, polina wrote:
> this can go away

Done.

[polina, 2011-07-12 17:56:58]

thanks for dropping all async's!!!

LGTM

[sehr (please use chromium), 2011-07-12 19:08:37]

On 2011/07/12 17:56:58, polina wrote:
> thanks for dropping all async's!!!
> 
> LGTM

Committed as r6010.