Issue 729173002: http://skbug.com/3130 step 1 (to fix chromium roll)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 729173002: http://skbug.com/3130 step 1 (to fix chromium roll) (Closed)

Created:
6 years, 1 month ago by hal.canary

Modified:
6 years, 1 month ago

Reviewers:
bsalomon, djsollen

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

http://skbug.com/3130 step 1 (to fix chromium roll) BUG=skia:3130 TBR=djsollen@google.com, bsalomon@google.com Committed: https://skia.googlesource.com/skia/+/21041e0cc4d3de1ae147369d76f3621a60c15625

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	gyp/utils.gypi	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/729173002/1

6 years, 1 month ago (2014-11-15 13:42:22 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/21041e0cc4d3de1ae147369d76f3621a60c15625

6 years, 1 month ago (2014-11-15 14:11:23 UTC) #3

djsollen

how does this fix the roll? Don't we just need to remove the unnecessary lines ...

6 years, 1 month ago (2014-11-18 13:27:47 UTC) #4

hal.canary

6 years, 1 month ago (2014-11-18 14:35:11 UTC) #5

Message was sent while issue was closed.

On 2014/11/18 13:27:47, djsollen wrote:
> how does this fix the roll?  Don't we just need to remove the unnecessary
lines
> from chromiums gyp and gn files?

Yep.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages