Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 728983004: Let git ignore the third_party dir to avoid unnecessary clean-ups. (Closed)

Created:
6 years, 1 month ago by Michael Achenbach
Modified:
6 years ago
CC:
v8-dev, tfarina
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Let git ignore the third_party dir to avoid unnecessary clean-ups. BUG=chromium:433273 LOG=n NOTRY=true Committed: https://chromium.googlesource.com/v8/v8/+/b1c5d0397076363a273b9998b8bc6e78f5582df2

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
PTAL. See attached bug. Bot_update runs "git clean -dff" which removes third_party/icu on each update. ...
6 years, 1 month ago (2014-11-15 16:38:02 UTC) #2
jochen (gone - plz use gerrit)
lgtm.
6 years, 1 month ago (2014-11-15 16:40:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/728983004/1
6 years, 1 month ago (2014-11-15 19:32:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-15 19:33:13 UTC) #6
tfarina
6 years ago (2014-12-03 15:41:45 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/728983004/diff/1/.gitignore
File .gitignore (right):

https://codereview.chromium.org/728983004/diff/1/.gitignore#newcode70
.gitignore:70: /third_party/icu
Now that you ignore the whole third_party/ dir, you may remove this entry and
the llvm one below?

Powered by Google App Engine
This is Rietveld 408576698