Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 72893003: MIPS: Inline zero argument array constructor. (Closed)

Created:
7 years, 1 month ago by kilvadyb
Modified:
7 years, 1 month ago
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@gbl
Visibility:
Public.

Description

MIPS: Inline zero argument array constructor. Port r17741 (fe14ef8) Original commit message: patch from issue 54583003 (dependent code). Zero arguments - very easy 1 argument - three special cases: a) If length is a constant in valid array length range, no need to check it at runtime. b) respect DoNotInline feedback on the AllocationSite for cases that the argument is not a smi or is an integer with a length that should create a dictionary. c) if kind feedback is non-holey, and length is non-constant, we'd have to generate a lot of code to be correct. Don't inline this case. N arguments - one special case: a) If a deopt ever occurs because an input argument isn't compatible with the elements kind, then set the DoNotInline flag. BUG=

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M src/mips/code-stubs-mips.cc View 2 chunks +10 lines, -5 lines 1 comment Download
M src/mips/stub-cache-mips.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
kilvadyb
7 years, 1 month ago (2013-11-14 17:59:12 UTC) #1
Paul Lind
LGTM, I will fix the nit when I land it. https://codereview.chromium.org/72893003/diff/1/src/mips/code-stubs-mips.cc File src/mips/code-stubs-mips.cc (right): https://codereview.chromium.org/72893003/diff/1/src/mips/code-stubs-mips.cc#newcode6008 ...
7 years, 1 month ago (2013-11-14 18:36:14 UTC) #2
Paul Lind
7 years, 1 month ago (2013-11-14 18:46:52 UTC) #3
Committed as r17759.

Powered by Google App Engine
This is Rietveld 408576698