Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1302)

Issue 728823002: Move WGL header from include to src (Closed)

Created:
6 years, 1 month ago by djsollen
Modified:
6 years, 1 month ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Move WGL header from include to src NOTRY=true Committed: https://skia.googlesource.com/skia/+/082a4620fdae4bc825738c789e976103fc083583

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -171 lines) Patch
M gyp/tools.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/utils.gypi View 2 chunks +1 line, -1 line 0 comments Download
D include/utils/SkWGL.h View 1 chunk +0 lines, -168 lines 0 comments Download
M src/gpu/gl/win/SkCreatePlatformGLContext_win.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + src/utils/win/SkWGL.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/views/win/SkOSWindow_win.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
djsollen
6 years, 1 month ago (2014-11-14 13:59:16 UTC) #2
bsalomon
lgtm, but maybe this should be in src/gpu? I think it was originally in utils ...
6 years, 1 month ago (2014-11-14 14:13:22 UTC) #3
djsollen
can't move it into src/gpu without making views.gyp dependent on skia_gpu being set to 1. ...
6 years, 1 month ago (2014-11-14 14:52:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/728823002/1
6 years, 1 month ago (2014-11-14 14:53:11 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/679)
6 years, 1 month ago (2014-11-14 15:00:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/728823002/1
6 years, 1 month ago (2014-11-14 15:21:24 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-14 15:21:33 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/082a4620fdae4bc825738c789e976103fc083583

Powered by Google App Engine
This is Rietveld 408576698