Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 728763006: bgsound must use the HTMLUnknownElement interface (Closed)

Created:
6 years ago by rwlbuis
Modified:
6 years ago
Reviewers:
tkent
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

bgsound must use the HTMLUnknownElement interface As specified here: https://html.spec.whatwg.org/#bgsound This causes one less fail on: http://w3c-test.org/html/semantics/interfaces.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186905

Patch Set 1 #

Patch Set 2 : Update test #

Patch Set 3 : bgsound only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M LayoutTests/fast/dom/wrapper-classes.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/wrapper-classes-expected.txt View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/html/HTMLTagNames.in View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
rwlbuis
PTAL
6 years ago (2014-12-10 20:53:44 UTC) #2
tkent
lgtm
6 years ago (2014-12-10 23:52:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/728763006/40001
6 years ago (2014-12-10 23:53:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/40761)
6 years ago (2014-12-11 01:50:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/728763006/40001
6 years ago (2014-12-11 02:49:39 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-11 03:46:55 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186905

Powered by Google App Engine
This is Rietveld 408576698