content/renderer/service_worker/service_worker_script_context.h - Issue 728763003: Introduce a //content/ API for dispatching notificationclick events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/service_worker/service_worker_script_context.h

Issue 728763003: Introduce a //content/ API for dispatching notificationclick events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/service_worker/service_worker_messages.h ('K') | « content/public/common/show_desktop_notification_params.h ('k') | content/renderer/service_worker/service_worker_script_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/service_worker/service_worker_script_context.h

diff --git a/content/renderer/service_worker/service_worker_script_context.h b/content/renderer/service_worker/service_worker_script_context.h

index 9bde541f0b8240d22c503d954ff2a8c369a3fd89..6400d8bf8d1b4b774fb91ebcf2c5ca3466a3fa4a 100644

--- a/content/renderer/service_worker/service_worker_script_context.h

+++ b/content/renderer/service_worker/service_worker_script_context.h

@@ -35,6 +35,7 @@ class Message;

namespace content {

class EmbeddedWorkerContextClient;

+struct ShowDesktopNotificationHostMsgParams;

// TODO(kinuko): This should implement WebServiceWorkerContextClient

// rather than having EmbeddedWorkerContextClient implement it.

@@ -92,8 +93,10 @@ class ServiceWorkerScriptContext {

void OnInstallEvent(int request_id, int active_version_id);

void OnFetchEvent(int request_id, const ServiceWorkerFetchRequest& request);

void OnSyncEvent(int request_id);

- void OnNotificationClickEvent(int request_id,

- const std::string& notification_id);

+ void OnNotificationClickEvent(

+ int request_id,

+ const std::string& notification_id,

+ const ShowDesktopNotificationHostMsgParams& notification_data);

void OnPushEvent(int request_id, const std::string& data);

void OnGeofencingEvent(int request_id,

blink::WebGeofencingEventType event_type,