content/common/service_worker/service_worker_messages.h - Issue 728763003: Introduce a //content/ API for dispatching notificationclick events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/service_worker/service_worker_messages.h

Issue 728763003: Introduce a //content/ API for dispatching notificationclick events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add a newline Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/notifications/notification_event_dispatcher_impl.cc ('K') | « content/browser/service_worker/service_worker_version.cc ('k') | content/content_browser.gypi » ('j') | content/public/browser/notification_event_dispatcher.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/service_worker/service_worker_messages.h

diff --git a/content/common/service_worker/service_worker_messages.h b/content/common/service_worker/service_worker_messages.h

index 2fb5a41e9b7f7d6612aaf77cc64bc603b6a688b5..50faee73d6201c5f573a079389c86b35c9e74ee6 100644

--- a/content/common/service_worker/service_worker_messages.h

+++ b/content/common/service_worker/service_worker_messages.h

@@ -10,6 +10,7 @@

#include "base/strings/string16.h"

#include "content/common/service_worker/service_worker_status_code.h"

#include "content/common/service_worker/service_worker_types.h"

+#include "content/public/common/show_desktop_notification_params.h"

#include "ipc/ipc_message_macros.h"

#include "ipc/ipc_param_traits.h"

#include "third_party/WebKit/public/platform/WebCircularGeofencingRegion.h"

@@ -369,9 +370,10 @@ IPC_MESSAGE_CONTROL2(ServiceWorkerMsg_FetchEvent,

content::ServiceWorkerFetchRequest)

IPC_MESSAGE_CONTROL1(ServiceWorkerMsg_SyncEvent,

int /* request_id */)

-IPC_MESSAGE_CONTROL2(ServiceWorkerMsg_NotificationClickEvent,

+IPC_MESSAGE_CONTROL3(ServiceWorkerMsg_NotificationClickEvent,

int /* request_id */,

- std::string /* notification_id */)

+ std::string /* notification_id */,

+ content::ShowDesktopNotificationHostMsgParams)

IPC_MESSAGE_CONTROL2(ServiceWorkerMsg_PushEvent,

int /* request_id */,

std::string /* data */)