Introduce a //content/ API for dispatching notificationclick events.

content/common/service_worker/service_worker_messages.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Message definition file, included multiple times, hence no include guard.
 
 #include <string>
 #include <vector>
 
 #include "base/strings/string16.h"
 #include "content/common/service_worker/service_worker_status_code.h"
 #include "content/common/service_worker/service_worker_types.h"
+#include "content/public/common/show_desktop_notification_params.h"
 #include "ipc/ipc_message_macros.h"
 #include "ipc/ipc_param_traits.h"
 #include "third_party/WebKit/public/platform/WebCircularGeofencingRegion.h"
 #include "third_party/WebKit/public/platform/WebGeofencingEventType.h"
 #include "third_party/WebKit/public/platform/WebServiceWorkerCacheError.h"
 #include "third_party/WebKit/public/platform/WebServiceWorkerError.h"
 #include "third_party/WebKit/public/platform/WebServiceWorkerEventResult.h"
 #include "url/gurl.h"
 
 #undef IPC_MESSAGE_EXPORT
@@ skipping 345 matching lines @@
 IPC_MESSAGE_CONTROL2(ServiceWorkerMsg_InstallEvent,
                      int /* request_id */,
                      int /* active_version_id */)
 IPC_MESSAGE_CONTROL1(ServiceWorkerMsg_ActivateEvent,
                      int /* request_id */)
 IPC_MESSAGE_CONTROL2(ServiceWorkerMsg_FetchEvent,
                      int /* request_id */,
                      content::ServiceWorkerFetchRequest)
 IPC_MESSAGE_CONTROL1(ServiceWorkerMsg_SyncEvent,
                      int /* request_id */)
-IPC_MESSAGE_CONTROL2(ServiceWorkerMsg_NotificationClickEvent,
+IPC_MESSAGE_CONTROL3(ServiceWorkerMsg_NotificationClickEvent,
                      int /* request_id */,
-                     std::string /* notification_id */)
+                     std::string /* notification_id */,
+                     content::ShowDesktopNotificationHostMsgParams)

[Mike West, 2014/12/09 11:47:30]

It's not clear what aspects of this struct you're actually using here. Do you
really need all of it?

[Peter Beverloo, 2014/12/09 11:51:58]

It's being used in service_worker_script_context.cc. I also added a TODO in the
file for ShowDesktopNotificationHostMsgParams to rename it to
PlatformNotificationData, and probably pull out the Bitmap (Icon) as part of
that.

Happy to send you a CL for that later today?

 IPC_MESSAGE_CONTROL2(ServiceWorkerMsg_PushEvent,
                      int /* request_id */,
                      std::string /* data */)
 IPC_MESSAGE_CONTROL4(ServiceWorkerMsg_GeofencingEvent,
                      int /* request_id */,
                      blink::WebGeofencingEventType /* event_type */,
                      std::string /* region_id */,
                      blink::WebCircularGeofencingRegion /* region */)
 IPC_MESSAGE_CONTROL3(ServiceWorkerMsg_MessageToWorker,
                      base::string16 /* message */,
@@ skipping 62 matching lines @@
                      blink::WebServiceWorkerCacheError)
 IPC_MESSAGE_CONTROL2(ServiceWorkerMsg_CacheMatchAllError,
                      int /* request_id */,
                      blink::WebServiceWorkerCacheError)
 IPC_MESSAGE_CONTROL2(ServiceWorkerMsg_CacheKeysError,
                      int /* request_id */,
                      blink::WebServiceWorkerCacheError)
 IPC_MESSAGE_CONTROL2(ServiceWorkerMsg_CacheBatchError,
                      int /* request_id */,
                      blink::WebServiceWorkerCacheError)