[ServiceWorker] Provide more descriptive error messages when fetch API fails.

[ServiceWorker] Provide more descriptive error messages when fetch API fails.

BUG=429060
TEST=http/tests/serviceworker/

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185418

[horo, 2014-11-14 07:29:29]

Patchset #1 (id:1) has been deleted

[horo, 2014-11-14 07:32:15]

horo@chromium.org changed reviewers:
+ falken@chromium.org

[horo, 2014-11-14 07:32:16]

falken@
Could you please review?

[falken, 2014-11-17 02:14:46]

This is great. But the Blink-specific error messages should not be tested in a
W3C test. Please move the tests to chromium/.

https://codereview.chromium.org/728713003/diff/20001/LayoutTests/http/tests/s...
File LayoutTests/http/tests/serviceworker/resources/fetch-worker.js (right):

https://codereview.chromium.org/728713003/diff/20001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/resources/fetch-worker.js:143: var url =
get_host_info()['HTTP_REMOTE_ORIGIN'] + '/dymmy.html';
nit: dummy

https://codereview.chromium.org/728713003/diff/20001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/resources/fetch-worker.js:201: }, 'Fetch
API error message - invalid chunled encoding.');
nit: chunked

https://codereview.chromium.org/728713003/diff/20001/Source/modules/servicewo...
File Source/modules/serviceworkers/FetchManager.cpp (right):

https://codereview.chromium.org/728713003/diff/20001/Source/modules/servicewo...
Source/modules/serviceworkers/FetchManager.cpp:133: failed("Fetch API cannot
load " + m_request->url().string() + ". Unsupported redirection.");
This message suggests there is a class of unsupported redirects. Are redirects
not supported at all? Then "Redirects are not yet supported" is better.
Otherwise, we should explain which class is supported/not supported.

https://codereview.chromium.org/728713003/diff/20001/Source/modules/servicewo...
Source/modules/serviceworkers/FetchManager.cpp:182: performNetworkError("Fetch
API cannot load " + m_request->url().string() + ". Request mode is
\"same-origin\" but the URL is not same origin.");
not the same origin as what?

[horo, 2014-11-17 03:25:35]

https://codereview.chromium.org/728713003/diff/20001/LayoutTests/http/tests/s...
File LayoutTests/http/tests/serviceworker/resources/fetch-worker.js (right):

https://codereview.chromium.org/728713003/diff/20001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/resources/fetch-worker.js:143: var url =
get_host_info()['HTTP_REMOTE_ORIGIN'] + '/dymmy.html';
On 2014/11/17 02:14:46, falken wrote:
> nit: dummy

Done.

https://codereview.chromium.org/728713003/diff/20001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/resources/fetch-worker.js:201: }, 'Fetch
API error message - invalid chunled encoding.');
On 2014/11/17 02:14:46, falken wrote:
> nit: chunked

Done.

https://codereview.chromium.org/728713003/diff/20001/Source/modules/servicewo...
File Source/modules/serviceworkers/FetchManager.cpp (right):

https://codereview.chromium.org/728713003/diff/20001/Source/modules/servicewo...
Source/modules/serviceworkers/FetchManager.cpp:133: failed("Fetch API cannot
load " + m_request->url().string() + ". Unsupported redirection.");
On 2014/11/17 02:14:46, falken wrote:
> This message suggests there is a class of unsupported redirects. Are redirects
> not supported at all? Then "Redirects are not yet supported" is better.
> Otherwise, we should explain which class is supported/not supported.

Done.

https://codereview.chromium.org/728713003/diff/20001/Source/modules/servicewo...
Source/modules/serviceworkers/FetchManager.cpp:182: performNetworkError("Fetch
API cannot load " + m_request->url().string() + ". Request mode is
\"same-origin\" but the URL is not same origin.");
On 2014/11/17 02:14:46, falken wrote:
> not the same origin as what?

Done.

[falken, 2014-11-17 03:29:59]

thanks! lgtm

[horo, 2014-11-17 03:38:58]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2014-11-17 03:39:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/728713003/60001

[commit-bot: I haz the power, 2014-11-17 05:44:01]

Committed patchset #3 (id:60001) as 185418